Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for the filter arg in community.BigQueryVectorStore #739

Merged
merged 6 commits into from
Feb 23, 2025

Conversation

cmenon12
Copy link
Contributor

PR Description

In BigQueryVectorStore:

  • Update docs for the filter arg to reflect the fact that it can be a dictionary or a string, and so that the IDE correctly displays them.
  • Override the five similarity search methods to update their docs and type hints for the filter arg to reflect that fact that it can be a dictionary or a string. These overriding methods all just call the superclass methods.

In BigQueryVectorStore and BaseBigQueryVectorStore fix the indentation of the docs, so that the IDE correctly displays them.

Relevant issues

None

Type

🧹 Refactoring
📖 Documentation

Changes(optional)

Testing(optional)

Note(optional)

There should be no functional changes, only to the documentation and the type hints to reflect functionality that already exists.

@cmenon12 cmenon12 marked this pull request as ready for review February 19, 2025 20:02
@cmenon12
Copy link
Contributor Author

Hi @lkuligin this is ready for review

@cmenon12
Copy link
Contributor Author

@lkuligin sorry for the linter failure, I've copied in the code from the super class methods instead of calling the super class methods directly, to avoid the type issue. Please let me know if this is not a good approach.

@lkuligin lkuligin merged commit 0b6249a into langchain-ai:main Feb 23, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants