Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nesting of conditional branches causing streaming output error #14065

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Nov1c444
Copy link
Collaborator

@Nov1c444 Nov1c444 commented Feb 20, 2025

Summary

Fixed an issue: When multiple conditional branches are connected, the streaming output of subsequent conditional branches will fail.

Fix #13626

Screenshots

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Feb 20, 2025
@Nov1c444 Nov1c444 marked this pull request as draft February 20, 2025 02:30
@Nov1c444 Nov1c444 changed the title fix: conditional node in parallel execution cause streaming output error fix: nesting of conditional branches causing streaming output error Feb 21, 2025
@Nov1c444 Nov1c444 marked this pull request as ready for review February 24, 2025 01:05
@Nov1c444 Nov1c444 marked this pull request as draft February 24, 2025 01:11
@Nov1c444 Nov1c444 marked this pull request as ready for review February 24, 2025 06:49
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming Response Broken: Integration of Question Classifier with Conditional Logic Before LLM Node
1 participant