Error: comma in translation key in email template #54740
-
|
I have noticed that the email template contains a comma in the translation key for the salutation “Regards”. This is problematic because punctuation marks such as commas should not be part of the translation key, as they are language-specific and not part of the translatable text. |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 1 reply
-
|
some languages use a different set of punctuation. for example in Chinese/Japanese/Korean comma is |
Beta Was this translation helpful? Give feedback.
-
|
The comma is just on the key, you can use whatever punctuation in the translated text. The key could be anything, a constant in all caps, for example. The key is a phrase in English, so it defaults to it when translating files are missing. But including the trailing comma makes no difference. As @cwang22 said, that allows to use different punctuation symbols when translating to languages which use different symbols. Or even none at all. I usually don't have a trailing comma for this translation in Portuguese, as it is optional by some style guides in Portuguese on these kinds of ending statements before a sender's name. On another project for a client, they asked to use the company's motto ended by an exclamation mark. IMO, no punctuation should be hard-coded in a way it couldn't be replaced by translation. As it is right now. |
Beta Was this translation helpful? Give feedback.
-
|
All right. I actually didn't think this through that far and just wondered why the greeting formula alone is not translated in the emails until I saw that the key is used without a comma in the language file. Thinking further, it actually makes more sense to pick up the key with a comma. Thank you very much! |
Beta Was this translation helpful? Give feedback.
-
|
You're welcome! Have a nice day =) |
Beta Was this translation helpful? Give feedback.
The comma is just on the key, you can use whatever punctuation in the translated text. The key could be anything, a constant in all caps, for example.
The key is a phrase in English, so it defaults to it when translating files are missing. But including the trailing comma makes no difference.
As @cwang22 said, that allows to use different punctuation symbols when translating to languages which use different symbols.
Or even none at all. I usually don't have a trailing comma for this translation in Portuguese, as it is optional by some style guides in Portuguese on these kinds of ending statements before a sender's name.
On another project for a client, they asked to use the company's mott…