Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to "default enabled" behavior of checking out when cloning #619

Merged
merged 3 commits into from
Mar 4, 2017

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Mar 2, 2017

This adds back a renamed version of the old BOOL options and sets a GTCheckoutOptions with sane defaults.

Fixes #618

This adds back a renamed version of the old BOOL options and sets a GTCheckoutOptions with sane defaults
@pietbrauer
Copy link
Member

Thanks a lot!

Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed something can you have a look in why the tests are failing? There is more than the usual error.

@tiennou
Copy link
Contributor Author

tiennou commented Mar 3, 2017

Oops, forgot to rename the options in the tests. Will fix !

@tiennou
Copy link
Contributor Author

tiennou commented Mar 3, 2017

Should be good to go. Hopefully. I can't run tests locally, so this is a blind fix.

Copy link
Member

@pietbrauer pietbrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pietbrauer pietbrauer merged commit e52feca into libgit2:master Mar 4, 2017
@tiennou tiennou deleted the fix-clone-checkout branch June 19, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants