Skip to content

[router] Fix in-flight request check in router shutdown #4604

[router] Fix in-flight request check in router shutdown

[router] Fix in-flight request check in router shutdown #4604

Triggered via pull request February 26, 2025 02:58
Status Failure
Total duration 13m 29s
Artifacts 19
Matrix: Clients / UT & CodeCov
Matrix: Controller / UT & CodeCov
Matrix: Integrations / UT & CodeCov
Matrix: Internal / UT & CodeCov
Matrix: Router / UT & CodeCov
Matrix: Server / UT & CodeCov
Matrix: StaticAnalysis
ValidateGradleWrapper
9s
ValidateGradleWrapper
StaticAnalysisAndUnitTestsCompletionCheck
0s
StaticAnalysisAndUnitTestsCompletionCheck
Fit to window
Zoom out
Zoom in

Annotations

52 errors
Router / UT & CodeCov (8)
Process completed with exit code 1.
Router / UT & CodeCov (17)
Process completed with exit code 1.
InstanceSizeEstimatorTest.testInstanceMeasurement: internal/venice-common/src/test/java/com/linkedin/venice/memory/InstanceSizeEstimatorTest.java#L46
java.lang.AssertionError: Class KafkaKey has a memoryAllocatedPerInstance (160.58428) which is too far from the predictedUsage (40); delta: 3.015; maxAllowedDelta: 0.010. No more attempts left.
InstanceSizeEstimatorTest.testInstanceMeasurement: internal/venice-common/src/test/java/com/linkedin/venice/memory/InstanceSizeEstimatorTest.java#L46
java.lang.AssertionError: Class KafkaKey has a memoryAllocatedPerInstance (160.58428) which is too far from the predictedUsage (40); delta: 3.015; maxAllowedDelta: 0.010. No more attempts left.
Router / UT & CodeCov (11)
Process completed with exit code 1.
SITWithPWiseAndBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false): clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
Wanted but not invoked: hostLevelIngestionStats.recordTotalBytesConsumed( <any long> ); -> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:499) However, there were exactly 27 interactions with this mock: hostLevelIngestionStats.recordProcessConsumerActionLatency( 1.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.007284d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:773) hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency( 0.118903d, 1740539011418L ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1304) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1309) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1637) hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency( 0.079479d, 1740539011421L ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1304) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1309) hostLevelIngestionStats.recordTotalRecordsConsumed(); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2633) hostLevelIngestionStats.recordProcessConsumerActionLatency( 0.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.054732d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:773) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1637) hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency( 0.065692d, 1740539011431L ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1304) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1309) hostLevelIngestionStats.recordTotalRecordsConsumed(); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2633) hostLevelIngestionStats.recordTotalRecordsConsumed(); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2633) hostLevelIngestionStats.recordProcessConsumerActionLatency( 0.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.002013d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:773) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1637) hostLevelIngestionStats.recordProcessConsumerActionLatency( 0.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.001954d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.check
SITWithPWiseAndBufferAfterLeaderTest.testRecordLevelMetricForCurrentVersion[0](false): clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
Wanted but not invoked: hostLevelIngestionStats.recordTotalBytesConsumed( <any long> ); -> at com.linkedin.davinci.stats.HostLevelIngestionStats.recordTotalBytesConsumed(HostLevelIngestionStats.java:499) However, there were exactly 27 interactions with this mock: hostLevelIngestionStats.recordProcessConsumerActionLatency( 1.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.007284d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:773) hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency( 0.118903d, 1740539011418L ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1304) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1309) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1637) hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency( 0.079479d, 1740539011421L ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1304) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1309) hostLevelIngestionStats.recordTotalRecordsConsumed(); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2633) hostLevelIngestionStats.recordProcessConsumerActionLatency( 0.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.054732d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:773) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1637) hostLevelIngestionStats.recordConsumerRecordsQueuePutLatency( 0.065692d, 1740539011431L ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1304) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.produceToStoreBufferServiceOrKafka(StoreIngestionTask.java:1309) hostLevelIngestionStats.recordTotalRecordsConsumed(); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2633) hostLevelIngestionStats.recordTotalRecordsConsumed(); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerRecord(StoreIngestionTask.java:2633) hostLevelIngestionStats.recordProcessConsumerActionLatency( 0.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.002013d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.checkLongRunningTaskState(LeaderFollowerStoreIngestionTask.java:773) hostLevelIngestionStats.recordStorageQuotaUsed( NaNd ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.recordQuotaMetrics(StoreIngestionTask.java:1637) hostLevelIngestionStats.recordProcessConsumerActionLatency( 0.0d ); -> at com.linkedin.davinci.kafka.consumer.StoreIngestionTask.processConsumerActions(StoreIngestionTask.java:1971) hostLevelIngestionStats.recordCheckLongRunningTasksLatency( 0.001954d ); -> at com.linkedin.davinci.kafka.consumer.LeaderFollowerStoreIngestionTask.check
SITWithPWiseAndBufferAfterLeaderTest.methodSetUp: clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
org.mockito.exceptions.misusing.CannotStubVoidMethodWithReturnValue: 'recordTotalPollRequestLatency' is a *void method* and it *cannot* be stubbed with a *return value*! Voids are usually stubbed with Throwables: doThrow(exception).when(mock).someVoidMethod(); If you need to set the void method to do nothing you can use: doNothing().when(mock).someVoidMethod(); For more information, check out the javadocs for Mockito.doNothing(). *** If you're unsure why you're getting above error read on. Due to the nature of the syntax above problem might occur because: 1. The method you are trying to stub is *overloaded*. Make sure you are calling the right overloaded version. 2. Somewhere in your test you are stubbing *final methods*. Sorry, Mockito does not verify/stub final methods. 3. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies - - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method. 4. Mocking methods declared on non-public parent classes is not supported.
SITWithPWiseAndBufferAfterLeaderTest.methodCleanUp: clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
org.mockito.exceptions.misusing.CannotStubVoidMethodWithReturnValue: 'recordTotalAvgPartitionsPerConsumer' is a *void method* and it *cannot* be stubbed with a *return value*! Voids are usually stubbed with Throwables: doThrow(exception).when(mock).someVoidMethod(); If you need to set the void method to do nothing you can use: doNothing().when(mock).someVoidMethod(); For more information, check out the javadocs for Mockito.doNothing(). *** If you're unsure why you're getting above error read on. Due to the nature of the syntax above problem might occur because: 1. The method you are trying to stub is *overloaded*. Make sure you are calling the right overloaded version. 2. Somewhere in your test you are stubbing *final methods*. Sorry, Mockito does not verify/stub final methods. 3. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies - - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method. 4. Mocking methods declared on non-public parent classes is not supported.
SITWithPWiseAndBufferAfterLeaderTest.methodSetUp: clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
org.mockito.exceptions.misusing.CannotStubVoidMethodWithReturnValue: 'recordTotalPollRequestLatency' is a *void method* and it *cannot* be stubbed with a *return value*! Voids are usually stubbed with Throwables: doThrow(exception).when(mock).someVoidMethod(); If you need to set the void method to do nothing you can use: doNothing().when(mock).someVoidMethod(); For more information, check out the javadocs for Mockito.doNothing(). *** If you're unsure why you're getting above error read on. Due to the nature of the syntax above problem might occur because: 1. The method you are trying to stub is *overloaded*. Make sure you are calling the right overloaded version. 2. Somewhere in your test you are stubbing *final methods*. Sorry, Mockito does not verify/stub final methods. 3. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies - - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method. 4. Mocking methods declared on non-public parent classes is not supported.
SITWithPWiseAndBufferAfterLeaderTest.methodCleanUp: clients/da-vinci-client/src/test/java/com/linkedin/davinci/kafka/consumer/SITWithPWiseAndBufferAfterLeaderTest.java#L1
org.mockito.exceptions.misusing.CannotStubVoidMethodWithReturnValue: 'recordTotalAvgPartitionsPerConsumer' is a *void method* and it *cannot* be stubbed with a *return value*! Voids are usually stubbed with Throwables: doThrow(exception).when(mock).someVoidMethod(); If you need to set the void method to do nothing you can use: doNothing().when(mock).someVoidMethod(); For more information, check out the javadocs for Mockito.doNothing(). *** If you're unsure why you're getting above error read on. Due to the nature of the syntax above problem might occur because: 1. The method you are trying to stub is *overloaded*. Make sure you are calling the right overloaded version. 2. Somewhere in your test you are stubbing *final methods*. Sorry, Mockito does not verify/stub final methods. 3. A spy is stubbed using when(spy.foo()).then() syntax. It is safer to stub spies - - with doReturn|Throw() family of methods. More in javadocs for Mockito.spy() method. 4. Mocking methods declared on non-public parent classes is not supported.
DispatchingAvroGenericStoreClientTest.testBatchGet: clients/venice-client/src/test/java/com/linkedin/venice/fastclient/DispatchingAvroGenericStoreClientTest.java#L1
org.testng.internal.thread.ThreadTimeoutException: Method com.linkedin.venice.fastclient.DispatchingAvroGenericStoreClientTest.testBatchGet() didn't finish within the time-out 10000
DispatchingAvroGenericStoreClientTest.testBatchGetToUnreachableClient: clients/venice-client/src/test/java/com/linkedin/venice/fastclient/DispatchingAvroGenericStoreClientTest.java#L1010
java.lang.AssertionError: Cannot invoke "java.util.concurrent.CompletableFuture.whenComplete(java.util.function.BiConsumer)" because "transportClientFutureForRoute" is null expected [true] but found [false]
DispatchingAvroGenericStoreClientTest.testBatchGet: clients/venice-client/src/test/java/com/linkedin/venice/fastclient/DispatchingAvroGenericStoreClientTest.java#L1
org.testng.internal.thread.ThreadTimeoutException: Method com.linkedin.venice.fastclient.DispatchingAvroGenericStoreClientTest.testBatchGet() didn't finish within the time-out 10000
DispatchingAvroGenericStoreClientTest.testBatchGetToUnreachableClient: clients/venice-client/src/test/java/com/linkedin/venice/fastclient/DispatchingAvroGenericStoreClientTest.java#L1010
java.lang.AssertionError: Cannot invoke "java.util.concurrent.CompletableFuture.whenComplete(java.util.function.BiConsumer)" because "transportClientFutureForRoute" is null expected [true] but found [false]
StaticAnalysisAndUnitTestsCompletionCheck
Process completed with exit code 1.

Artifacts

Produced during runtime
Name Size
StaticAnalysis
664 KB
clients-jdk11
2.58 MB
clients-jdk17
2.61 MB
clients-jdk8
2.53 MB
controller-jdk11
1.58 MB
controller-jdk17
1.57 MB
controller-jdk8
1.6 MB
integrations-jdk11
523 KB
integrations-jdk17
527 KB
integrations-jdk8
512 KB
internal-jdk11
3.49 MB
internal-jdk17
3.5 MB
internal-jdk8
3.48 MB
router-jdk11
548 KB
router-jdk17
538 KB
router-jdk8
541 KB
server-jdk11
10.5 MB
server-jdk17
9.7 MB
server-jdk8
9.27 MB