[changelog][client] Add viewname to changelog client factory #1554
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allows setting a view per consumer This is to enable cases where we need to be able to consume different views for different stores.
xunyin8
reviewed
Feb 26, 2025
| String viewNameOverride) { | ||
| String adjustedConsumerId; | ||
| if (!StringUtils.isEmpty(viewNameOverride)) { | ||
| adjustedConsumerId = consumerId + "-" + viewNameOverride; |
There was a problem hiding this comment.
If consumerId is null this concat will actually resolve to null-<viewNameOverride> which functionally I don't think it makes a difference in:
private String suffixConsumerIdToStore(String storeName, String consumerId) {
return StringUtils.isEmpty(consumerId) ? storeName : storeName + "-" + consumerId;
}
and storeClientMap.computeIfAbsent but I think we should still fix it to avoid confusion and potential side effects in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[changelog][client] Add viewname to changelog client factory
This is to enable cases where we need to be able to consume different views for different stores.
Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?