Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix language setting only available in view #1117

Merged
merged 1 commit into from
Feb 23, 2023
Merged

fix language setting only available in view #1117

merged 1 commit into from
Feb 23, 2023

Conversation

dairidong
Copy link
Contributor

@dairidong dairidong commented Feb 10, 2023

the language setting is always english except in the blade template.

@keriati
Copy link
Collaborator

keriati commented Feb 11, 2023

@dairidong what is this fix actually doing? Can you add a screenshot maybe with the problem?

@dairidong
Copy link
Contributor Author

dairidong commented Feb 12, 2023

Example, translation can't work in controller, it is always english.
https://github.com/linuxserver/Heimdall/blob/2.x/app/Http/Controllers/SettingsController.php#L103

return redirect($route)
    ->with([
         'success' => __('app.alert.success.setting_updated'),
    ]);

image

Copy link
Collaborator

@keriati keriati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keriati keriati merged commit cefe07d into linuxserver:2.x Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants