Wide rivers #76
Merged
Wide rivers #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 15, 2024 22:34
|
I love your inversed floodfill approach. |
|
@louis-e Sorry, I was out for a wedding late last night and only just got up. I think we should to revert this PR and #75 as they were both draft PRs. This one I'm working on optimizing more (and tbh, it should probably be tested a bit more as I refactored a bunch of code) and the other one I left some questions on in the PR. |
|
Actually, we'd probably okay to not revert (I can put up new PRs to finish things) but #75 has a few questions I was wondering about |
|
Sorry for all the spam, but my open PRs should fix all the WIP stuff! Can probably ignore my above comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on adding rivers. Code works as-is, but it's very slow. Takes about 40 minutes to run on my small city. Have some improvements locally but I haven't pushed them up yet.
This required a bit of refactoring so that we could handle relations. I cleaned up some related code at the same time. And this is also based on my other PRs, so I recommend looking at them first (as some of their code is duplicated in this PR)
Before:
After:
This makes a big difference to how my city looks!