Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FingerUp causing UITouch to end in start location #35

Merged
merged 3 commits into from
Dec 11, 2021

Conversation

nsoojin
Copy link
Contributor

@nsoojin nsoojin commented Dec 4, 2021

@gabriellanata Hey buddy,

There is a a bug in fingerUp where the location in touchesEnded callback is the start position of the drag(e.g. fingerDown). It is because FingerInfo only holds the initial location of the finger, so when I call fingerUp, it will cause the final touch on the initial point, not where the drag has ended.

To reproduce, comment out this line and run the DragTests I put in.

Once again, I greatly appreciate this library you put together. It has opened up fantastic automated testing suites for my app.

@gabriellanata gabriellanata self-requested a review December 8, 2021 21:49
@gabriellanata gabriellanata added the bug Something isn't working label Dec 8, 2021
gabriellanata
gabriellanata previously approved these changes Dec 8, 2021
Copy link
Contributor

@gabriellanata gabriellanata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! We should probably throw some errors here if the identifier does not exist. Honestly we should probably add a bunch more sanity checks in the rest of the methods in this file. I can add those after your PR merges though.

@nsoojin
Copy link
Contributor Author

nsoojin commented Dec 11, 2021

hey @gabriellanata,
when are you planning to merge it and release a new version?

@gabriellanata gabriellanata merged commit 6006079 into lyft:main Dec 11, 2021
@gabriellanata
Copy link
Contributor

hey @gabriellanata,

when are you planning to merge it and release a new version?

Yes sorry, had to fix CI

@gabriellanata
Copy link
Contributor

#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants