[python] Don't throw error directly when emitter crash #6104
+98
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:python
|
You can try these changes here
|
|
All changed packages have been documented.
Show changes
|
iscai-msft
reviewed
Feb 25, 2025
| severity: "error", | ||
| messages: { | ||
| default: | ||
| "Python is not installed. Please follow https://www.python.org/ to install Python or set 'use-pyodide' to true.", |
There was a problem hiding this comment.
this shouldn't be an error, because we should automatically call use-pyodide if that is the case. The only way an error like this would occur is if someone explicitly set use-pyodide=false without having python. In that case, I think the error name would be better being something like pyodide-flag-conflict or something like that
There was a problem hiding this comment.
Make sense and I think pyodide-flag-conflict is reasonable here.
Updated.
tadelesh
approved these changes
Feb 26, 2025
| "unknown-error": { | ||
| severity: "error", | ||
| messages: { | ||
| default: paramMessage`Can't generate Python client code from this TypeSpec, please open an issue on https://github.com/microsoft/typespec'.\n${"stack"}`, |
There was a problem hiding this comment.
Suggested change
| default: paramMessage`Can't generate Python client code from this TypeSpec, please open an issue on https://github.com/microsoft/typespec'.\n${"stack"}`, | |
| default: paramMessage`Can't generate Python client code from this TypeSpec. Please open an issue on https://github.com/microsoft/typespec'.${"stack"}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6081
We shall not throw error when emitter crash. Instead, we should catch the errors then report them with
reportDiagnosticprovided by compiler: