Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config overhaul #633

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Config overhaul #633

wants to merge 3 commits into from

Conversation

miniscruff
Copy link
Owner

TODO: fill me in

Closes #NNN

Check the following

  • Keep 100% code coverage
  • Be properly formatted
  • Documentation changes are included
  • Include a change file if expected

Additional context
Any additional info that might help get your pull request merged.

@miniscruff
Copy link
Owner Author

Feel like I should update this, its been a while.

I am just not sure its worth the burden to support two different configuration schemas as it would be a very backwards incompatible change to not do so. There also aren't enough other improvements to changie to justify a v2.

One option would be to swap from the old style to the new style with an auto upgrade script, but I am not sure I can assume everyone would be willing to run the command to update the config. It would be a per-requisite to get any new config options but I would have to not only build the config swap command but support it for the foreseeable future.

There is also a hybrid approach where we support both for a time, then we create the auto upgrade script, support that for a time and then eventually drop it? Or maybe just support it until a v2 comes out.

All in all, I am not sure the new config schema will come out anytime soon unless there is a bigger push then there is currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant