Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-298469: Fix notificaiton GH aciton to not create a ticket in the event of error #417

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Feb 10, 2025

Proposed changes

Jira ticket: CLOUDP-298469

Bug: the action was creating a new Jira ticket when the JIRA API to find similar ticket returned an error.

This PR updates the logic to:

  • avoid creating a new JIRA ticket in the event of error from the Jira API call that search for similar Jira ticket
  • Update the title of the ticket. During my local testing, I discovered that the JIRA API returns an error if using [API Platform] in the title. Removing this prefix makes the JIRA API happy again.

@andreaangiolillo andreaangiolillo changed the title CLOUDP-298469: CLOUDP-298469: Fix notificaiton GH aciton to not create a ticket in the event of error Feb 10, 2025
@andreaangiolillo andreaangiolillo marked this pull request as ready for review February 10, 2025 11:09
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner February 10, 2025 11:09
@andreaangiolillo andreaangiolillo merged commit 10a26d6 into main Feb 10, 2025
12 checks passed
@andreaangiolillo andreaangiolillo deleted the CLOUDP-298469 branch February 10, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants