Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix to ignore press event when button is disabled #3056

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: fix to ignore press event when button is disabled #3056

merged 1 commit into from
Feb 10, 2025

Conversation

gs18004
Copy link
Contributor

@gs18004 gs18004 commented Feb 9, 2025 •
edited
Loading

closes #3055

Now, onTap callback does not fire when button has disabled prop set to true.

@gs18004
Copy link
Contributor Author

gs18004 commented Feb 9, 2025

Test fails, but I think this is not the problem with my code. The problem in the test result is not related to my commit.

michTheBrandofficial
michTheBrandofficial reviewed Feb 9, 2025
View reviewed changes
Copy link

@michTheBrandofficial michTheBrandofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine man. Thanks for the fix

@mattgperry
Copy link
Collaborator

Banger PR, thanks!

@mattgperry mattgperry merged commit 37751df into motiondivision:main Feb 10, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michTheBrandofficial michTheBrandofficial michTheBrandofficial left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] onTap callback fires when button has disabled prop set to true
3 participants
@gs18004 @mattgperry @michTheBrandofficial