Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added to CMakeLists.txt reading from file and parsing xeve version st… #52

Merged
merged 3 commits into from
May 22, 2022
Merged

Added to CMakeLists.txt reading from file and parsing xeve version st… #52

merged 3 commits into from
May 22, 2022

Conversation

dkozinski
Copy link
Collaborator

…ring

dkozinski added 2 commits May 19, 2022 13:57
@dkozinski
The type of message reported during project configuration if the vers…
5815785 
…ion sring has incorrct format has been changed from WARNING to FATAL_ERROR
@dkozinski
Added missing version.txt file
81c0b71
dariusz-f
dariusz-f approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@dariusz-f dariusz-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging this pull request it will be good to release xeve with new relase tag v1.0.0 same as in version txt.

kpchoi
kpchoi approved these changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@kpchoi kpchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great

@mpeg5 mpeg5 merged commit 7a57f0f into master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusz-f dariusz-f dariusz-f approved these changes

@kpchoi kpchoi kpchoi approved these changes

@mpeg5 mpeg5 Awaiting requested review from mpeg5

@mss-park mss-park Awaiting requested review from mss-park

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkozinski @dariusz-f @kpchoi @mpeg5