Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Update POST /workflows to link folder (no-changelog) #13449

Merged

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Feb 23, 2025

Based on PR #13448

Chain of upstream PRs as of 2025-02-23

Summary

Allows to link a workflow with a specific folder when the workflow is saved.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3259/[be]-link-folder-to-workflow-when-workflow-is-saved

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@RicardoE105 RicardoE105 self-assigned this Feb 23, 2025
@RicardoE105 RicardoE105 changed the title Update POST workflows to link folder feat(core): Update POST workflows to link folder (no-changelog) Feb 23, 2025
@RicardoE105 RicardoE105 changed the title feat(core): Update POST workflows to link folder (no-changelog) feat(core): Update POST /workflows to link folder (no-changelog) Feb 23, 2025
@RicardoE105 RicardoE105 force-pushed the ado-3258-be-add-endpoint-to-the-return-path-to-root-from-children branch from 162ed4a to 12f20ca Compare February 23, 2025 20:42
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@RicardoE105 RicardoE105 force-pushed the ado-3259-be-link-folder-to-workflow-when-workflow-is-saved branch from c73051a to ba43f9f Compare February 23, 2025 20:45
@RicardoE105 RicardoE105 requested a review from mutdmour February 23, 2025 20:45
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Feb 23, 2025
@RicardoE105 RicardoE105 force-pushed the ado-3258-be-add-endpoint-to-the-return-path-to-root-from-children branch from 12f20ca to c8b61f0 Compare February 24, 2025 12:24
@RicardoE105 RicardoE105 force-pushed the ado-3259-be-link-folder-to-workflow-when-workflow-is-saved branch from ba43f9f to c4ca94d Compare February 24, 2025 12:24
@RicardoE105 RicardoE105 force-pushed the ado-3258-be-add-endpoint-to-the-return-path-to-root-from-children branch from c8b61f0 to 02fb497 Compare February 24, 2025 13:07
@RicardoE105 RicardoE105 force-pushed the ado-3259-be-link-folder-to-workflow-when-workflow-is-saved branch from c4ca94d to ba46e20 Compare February 24, 2025 13:08
Cadiac
Cadiac previously approved these changes Feb 24, 2025
@Cadiac
Copy link
Contributor

Cadiac commented Feb 24, 2025

Check the failing postgres tests, I'm not sure if those are just flaky ?

@RicardoE105
Copy link
Contributor Author

@Cadiac having a look at the test

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 24, 2025

n8n    Run #9471

Run Properties:  status check passed Passed #9471  •  git commit 648565d0a5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Project n8n
Branch Review ado-3259-be-link-folder-to-workflow-when-workflow-is-saved
Run status status check passed Passed #9471
Run duration 04m 31s
Commit git commit 648565d0a5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 RicardoE105 🗃️ e2e/*
Committer Ricardo Espinoza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 437
View all changes introduced in this branch ↗︎

@RicardoE105 RicardoE105 requested a review from Cadiac February 24, 2025 20:46
@RicardoE105 RicardoE105 force-pushed the ado-3259-be-link-folder-to-workflow-when-workflow-is-saved branch from 9e40a9c to 5a086e4 Compare February 25, 2025 12:54
Copy link
Contributor

@Cadiac Cadiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I'm happy with the unresolved mystery on why the tests still passed locally without using the same transaction, but this should at least fix it on CI so lets get this in.

Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 461e39a into master Feb 25, 2025
45 checks passed
@RicardoE105 RicardoE105 deleted the ado-3259-be-link-folder-to-workflow-when-workflow-is-saved branch February 25, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants