-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Update POST /workflows
to link folder (no-changelog)
#13449
feat(core): Update POST /workflows
to link folder (no-changelog)
#13449
Conversation
workflows
to link folderworkflows
to link folder (no-changelog)
workflows
to link folder (no-changelog)/workflows
to link folder (no-changelog)
162ed4a
to
12f20ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
c73051a
to
ba43f9f
Compare
12f20ca
to
c8b61f0
Compare
ba43f9f
to
c4ca94d
Compare
c8b61f0
to
02fb497
Compare
c4ca94d
to
ba46e20
Compare
Check the failing postgres tests, I'm not sure if those are just flaky ? |
@Cadiac having a look at the test |
✅ All Cypress E2E specs passed |
n8n
|
Project |
n8n
|
Branch Review |
ado-3259-be-link-folder-to-workflow-when-workflow-is-saved
|
Run status |
|
Run duration | 04m 31s |
Commit |
|
Committer | Ricardo Espinoza |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
1
|
|
5
|
|
0
|
|
437
|
View all changes introduced in this branch ↗︎ |
9e40a9c
to
5a086e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I'm happy with the unresolved mystery on why the tests still passed locally without using the same transaction, but this should at least fix it on CI so lets get this in.
✅ All Cypress E2E specs passed |
Based on PR #13448
Chain of upstream PRs as of 2025-02-23
PR feat(core): Add endpoint POST
/projects/:projectId/folders
(no-changelog) #13446:master
←ado-3179-be-add-endpoint-to-create-folder-v2
PR feat(core): Add endpoint GET
/projects/:projectId/folders/:folderId/tree
(no-changelog) #13448:ado-3179-be-add-endpoint-to-create-folder-v2
←ado-3258-be-add-endpoint-to-the-return-path-to-root-from-children
/workflows
to link folder (no-changelog) #13449 (THIS ONE):ado-3258-be-add-endpoint-to-the-return-path-to-root-from-children
←ado-3259-be-link-folder-to-workflow-when-workflow-is-saved
Summary
Allows to link a workflow with a specific folder when the workflow is saved.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3259/[be]-link-folder-to-workflow-when-workflow-is-saved
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)