Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #24721; Table add missing sink #24724

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

fixes #24721; Table add missing sink #24724

wants to merge 2 commits into from
+18 −18

Conversation

ringabout
Copy link
Member

fixes #24721

@arnetheduck
Copy link
Contributor

this PR is nice because fixes Table, but he same applies to every stdlib module (sets, lists etc) - ie the ideal would be that they all got fixed together

@ringabout
Copy link
Member Author

same applies to every stdlib module (sets, lists etc) - ie the ideal would be that they all got fixed together

Okay, I will add them once tests pass for tables

@Araq
Copy link
Member

Araq commented Feb 25, 2025

ie the ideal would be that they all got fixed together

That's a bad idea for bisecting codegen regressions.

@arnetheduck
Copy link
Contributor

That's a bad idea for bisecting codegen regressions.

as long as I don't have to open an issue for every function 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table add missing sink
3 participants
@ringabout @arnetheduck @Araq