feat(dashboard): Add a disableOutputSanitization option for in app steps #7456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -215,6 +213,8 @@ export class ConstructFrameworkWorkflow { | |||
| // TODO: fix the `JSONSchemaDto` type to enforce a non-primitive schema type. | |||
| controlSchema: staticStep.template!.controls!.schema as JsonSchema, | |||
| skip: (controlValues: Record<string, unknown>) => this.processSkipOption(controlValues, fullPayloadForRender), | |||
| disableOutputSanitization: | |||
| (staticStep.controlVariables?.disableOutputSanitization as boolean | undefined) ?? false, | |||
There was a problem hiding this comment.
do we need to transfer this flat to boolean just in case we stored it in the db as "false"
in addition as mentioned in the DM staticStep.controlVariables is not available from the database. we need either fetch those controls or pass them from the framework to this scope.
desiprisg
force-pushed
the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
from
37d296e to
1e906ec
Compare
@novu/client
@novu/headless
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/shared
commit: |
desiprisg
force-pushed
the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
from
1e906ec to
f759279
Compare
desiprisg
force-pushed
the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
from
f759279 to
8b4c88e
Compare
desiprisg
force-pushed
the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
from
8b4c88e to
e98e667
Compare
desiprisg
force-pushed
the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
from
e98e667 to
16b350b
Compare
desiprisg
force-pushed
the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
from
16b350b to
a251050
Compare
SokratisVidros
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Looks good to me, great job! :)
Please ensure that we remove disableOutputSanitization in InAppOutputRendererUsecase, just like we remove skip. Unfortunately, we don’t have strict types there yet. I believe the framework (via the Output Schema) could throw a validation error for this mismatch.
On a related note, have we tested the full flow, including trigger execution?
SokratisVidros
force-pushed
the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
from
a251050 to
1b682f7
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
deleted the
nv-5142-sanitize-html-character-references-in-the-new-inbox-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer