fix(dashboard): fix issues on environment management NV-5232 #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -30,11 +30,12 @@ export class CreateEnvironment { | |||
| if (environmentCount >= 10) { | |||
| throw new BadRequestException('Organization cannot have more than 10 environments'); | |||
| } | |||
| const normalizedName = command.name.trim(); | |||
| @@ -19,7 +20,12 @@ export class UpdateEnvironment { | |||
| const updatePayload: Partial<EnvironmentEntity> = {}; | |||
|
|
|||
| if (command.name && command.name !== '') { | |||
| updatePayload.name = command.name; | |||
| const normalizedName = command.name.trim(); | |||
| if (PROTECTED_ENVIRONMENTS?.map((env) => env.toLowerCase()).includes(normalizedName.toLowerCase())) { | |||
There was a problem hiding this comment.
💭 thought (non-blocking): maybe we should extract this and reuse in case the validation will be updated again?
There was a problem hiding this comment.
Was thinking about it, but felt too dry for just a single validation right now, we can revise it if more complex logic will happen in the future
djabarovgeorge
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer