[ADD] sales: discounts #12115
[ADD] sales: discounts #12115
Conversation
|
|
|
Hi @larm-odoo this PR is ready for a peer review, when you have a moment. Thank you! |
There was a problem hiding this comment.
All set @dikd-odoo! Great document, easy to follow. Just a few suggestions, nothing major. Approved!
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
dikd-odoo
force-pushed
the
18.0-sales-discounts-dikd
branch
from
1417c43 to
21024ee
Compare
|
Thank you for the super thoughtful review @larm-odoo! I implemented your edits and suggestions and also tweaked a few more sections based on your questions. Hello @odoo/us-doc-review this PR is ready for final review, thank you! |
There was a problem hiding this comment.
Great call on separating the discount instructions into a dedicated page, @dikd-odoo!
That makes it much clearer. 😊 I just left a few minor rewording suggestions for brevity—feel free to take a look when you have a chance! 🚀
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
dikd-odoo
force-pushed
the
18.0-sales-discounts-dikd
branch
from
c2b6ced to
f40c1c4
Compare
|
Thank you for the helpful suggestions @Felicious! Implemented your edits and revised another image based on your suggestion to reduce the white space, which I think helps a lot. Hi @samueljlieber this PR is ready for technical review, when you have a moment. Thank you! |
There was a problem hiding this comment.
Hi @dikd-odoo! Nice work on this PR to update and separate this content into its own doc. I am approving with a small handful of technical changes, please address these before merge.
Be sure to run make review on the image folder (content/applications/sales/sales/products_prices/prices/discounts) to check for unused and uncompressed images :)
Thank you for your work!
.....
@robodoo delegate=dikd-odoo
...nt/applications/sales/sales/products_prices/prices/discounts/discount-on-sales-order-fs8.png
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts/global-discount-option.png
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts/discount-on-sales-order.png
Outdated
Show resolved
Hide resolved
.../applications/sales/sales/products_prices/prices/discounts/fixed-discount-on-sales-order.png
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/prices/discounts.rst
Outdated
Show resolved
Hide resolved
Apply suggestions from LARM review Co-authored-by: larm-odoo <[email protected]> edits Apply suggestions from FEKU review Co-authored-by: Felicia Kuan <[email protected]> edits edits2 edits3 Apply suggestions from SALI review Co-authored-by: Sam Lieber (sali) <[email protected]> edits
dikd-odoo
force-pushed
the
18.0-sales-discounts-dikd
branch
from
6ffe58d to
5420add
Compare
|
Thank you for the super helpful technical review, @samueljlieber! |
|
@robodoo r+ |
Creating new 'Discounts' page under Sales > Products & Prices > Manage Your Pricing and migrating current Discounts documentation for searchability and readability.
+Update text and images in documentation to match current style guide. Revising language and RST markup throughout document for brevity and clarity, as well as relevant details in use case.
Target: 18.0
Task: https://www.odoo.com/odoo/project/3835/tasks/4591281