Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor "disabled" on subitems. #829

Merged
merged 3 commits into from
Sep 28, 2020
Merged

Conversation

c-mauderer
Copy link
Contributor

What this PR does / why we need it:

This allows to disable subitems for example in the portfolio by setting disabled = true just like on other pages.

Special notes for your reviewer:

None.

Release note:

Honor "disabled" on subitems.

@stp-ip stp-ip requested a review from mpourismaiel September 25, 2020 15:38
stp-ip
stp-ip previously approved these changes Sep 25, 2020
Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. Makes sense. LGTM from my side. Happy for @mpourismaiel to merge.

@stp-ip stp-ip added this to the v0.18.0 milestone Sep 25, 2020
@stp-ip
Copy link
Member

stp-ip commented Sep 25, 2020

One small thing missing, that would be a nice to have would be a change to the docs or example code within exampleSite, which the docs page uses.
Other fragments have a commented "disabled" line in the example config.

@c-mauderer
Copy link
Contributor Author

One small thing missing, that would be a nice to have would be a change to the docs or example code within exampleSite, which the docs page uses.
Other fragments have a commented "disabled" line in the example config.

I'll add that. I hope that I find all locations where the subitems are used.

@c-mauderer
Copy link
Contributor Author

I noted that on the current version of the documentation a lot of the "code (subitem)" isn't really readable. It seems that the formatting isn't detected correctly. Reason seems to be that there is a blank line missing. For example for FAQ the following patch would fix that:

diff --git a/exampleSite/content/fragments/faq/code-faq.md b/exampleSite/content/fragments/faq/code-faq.md
index 27463521..2272b69f 100644
--- a/exampleSite/content/fragments/faq/code-faq.md
+++ b/exampleSite/content/fragments/faq/code-faq.md
@@ -17,6 +17,7 @@ background = "secondary"
 
 <details>
 <summary>Code (subitem)</summary>
+
 ```
 +++
 title = "How to sit on the laptop?"

Should I add a patch here or would you prefer an extra Pull Request for that?

@stp-ip
Copy link
Member

stp-ip commented Sep 25, 2020

Noticed this as well and put it on my offline notes, but happy to have this fixed.
Ok to have this within this PR as a separate commit.

It seems that a code block without a blank line before the ``` marker
isn't detected correctly.
@stp-ip
Copy link
Member

stp-ip commented Sep 25, 2020

Will merge this in the coming days, if Mahdi doesn't respond/merge.

@c-mauderer
Copy link
Contributor Author

Will merge this in the coming days, if Mahdi doesn't respond/merge.

Thank you.

Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stp-ip stp-ip merged commit 06699cd into okkur:master Sep 28, 2020
@stp-ip
Copy link
Member

stp-ip commented Sep 28, 2020

Thanks again and looking forward to more contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants