-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor "disabled" on subitems. #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR. Makes sense. LGTM from my side. Happy for @mpourismaiel to merge.
One small thing missing, that would be a nice to have would be a change to the docs or example code within exampleSite, which the docs page uses. |
I'll add that. I hope that I find all locations where the subitems are used. |
I noted that on the current version of the documentation a lot of the "code (subitem)" isn't really readable. It seems that the formatting isn't detected correctly. Reason seems to be that there is a blank line missing. For example for FAQ the following patch would fix that: diff --git a/exampleSite/content/fragments/faq/code-faq.md b/exampleSite/content/fragments/faq/code-faq.md
index 27463521..2272b69f 100644
--- a/exampleSite/content/fragments/faq/code-faq.md
+++ b/exampleSite/content/fragments/faq/code-faq.md
@@ -17,6 +17,7 @@ background = "secondary"
<details>
<summary>Code (subitem)</summary>
+
```
+++
title = "How to sit on the laptop?" Should I add a patch here or would you prefer an extra Pull Request for that? |
Noticed this as well and put it on my offline notes, but happy to have this fixed. |
It seems that a code block without a blank line before the ``` marker isn't detected correctly.
Will merge this in the coming days, if Mahdi doesn't respond/merge. |
Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks again and looking forward to more contributions :) |
What this PR does / why we need it:
This allows to disable subitems for example in the portfolio by setting
disabled = true
just like on other pages.Special notes for your reviewer:
None.
Release note: