Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor TPS #1240

Merged
merged 6 commits into from
Dec 5, 2022
Merged

[Refactor] Refactor TPS #1240

merged 6 commits into from
Dec 5, 2022

Conversation

Mountchicken
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

* loss

* fix

* [update] limit extension versions
Copy link
Collaborator

@gaotongxiao gaotongxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pytorch 1.3, the default behavior of grid_sample has been changed. Keeping align_corners=True is empirically crucial to the performance of STN

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 85.38% // Head: 85.56% // Increases project coverage by +0.17% 🎉

Coverage data is based on head (969b36c) compared to base (b8c445b).
Patch coverage: 94.95% of modified lines in pull request are covered.

❗ Current head 969b36c differs from pull request most recent head 5511c06. Consider uploading reports for the commit 5511c06 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1240      +/-   ##
===========================================
+ Coverage    85.38%   85.56%   +0.17%     
===========================================
  Files          160      162       +2     
  Lines         9994    10111     +117     
  Branches      1388     1391       +3     
===========================================
+ Hits          8533     8651     +118     
+ Misses        1215     1212       -3     
- Partials       246      248       +2     
Flag Coverage Δ
unittests 85.56% <94.95%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...odels/textrecog/preprocessors/base_preprocessor.py 83.33% <83.33%> (ø)
...models/textrecog/preprocessors/tps_preprocessor.py 95.57% <95.57%> (ø)
mmocr/datasets/transforms/textrecog_transforms.py 91.74% <0.00%> (-8.26%) ⬇️
mmocr/datasets/preparers/parsers/base.py 72.00% <0.00%> (-5.78%) ⬇️
...r/models/kie/postprocessors/sdmgr_postprocessor.py 92.64% <0.00%> (+7.35%) ⬆️
...cr/models/textdet/module_losses/pan_module_loss.py 96.79% <0.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaotongxiao
Copy link
Collaborator

gaotongxiao commented Nov 30, 2022

@Mountchicken You can merge this PR with the latest dev-1.x branch before I proceed to merge

@gaotongxiao gaotongxiao merged commit a12c215 into open-mmlab:dev-1.x Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants