-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix register bug of CLIPResNet #1517
Conversation
Hi, thanks for your contribution! Before we are able to merge your PR, please don't forget to sign CLA here :) Also, if you get an error message like "xxx seems not to be a GitHub user", it means that the email you used to commit changes does not match the one you used in your GitHub account. You can try to link your local email to your GitHub, or update your local email address and then amend your commits: git config --global user.email "YOUR_GITHUB_EMAIL"
git commit --amend |
Hi, I have signed CLA and changed user, you may check again? |
@jyshee Thanks! However, your git commit history still has "forrest.sjy" since you haven't cleaned up the old commits. The quickest way might be: git reset HEAD~5
git add .
git commit -m 'Fix register bug of CLIPResNet'
git push -f |
Sorry for troubles, what about now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch diverged from dev-1.x which I had fixed for you. Thanks for your contribution!
Hi @jyshee !First of all, we want to express our gratitude for your significant PR in the MMOCR project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) |
Motivation
Fix CLIPResNet register isssue reported at #1515
Modification
Add
from .plugins import * # NOQA
into mmocr/models/common/init.py.Checklist
Before PR:
After PR: