call after_val_epoch hooks only once to save best ckpt correctly #421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
SingleTeacherDistillValLoop
callsafter_val_epoch
hooks twice during the evaluation. However, the metric in the second call do not contain the key namedstudent.accuracy/top1
. As a result, if we setsave_best='auto'
inCheckpointHook
, the program will fail.Please refer to this issue for more details.
Modification
Now we only call
after_val_epoch
hooks once inSingleTeacherDistillValLoop
.