Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: add annotation for validated SCC type #2211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Feb 25, 2025

What

Add annotation for validated SCC type (User / ServiceAccount).

Why

An SCC is being assigned to a workload based on the capabilities the ServiceAccount or user has. To distinct, against whom this was validated against, this annotation is being introduced.

This is necessary to identify namespaces that might not be labeled properly by the PSA label syncer as it doesn't watch the user's SCCs and picks the wrong PodSecurityStandard for PodSecurityAdmission labels.

Reference

An SCC is being assigned to a workload based on the capabilities the
ServiceAccount or user has. To distinct, against whom this was validated
against, this annotation is being introduced.
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

Hello @ibihim! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2025
@kramaranya
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibihim, kramaranya
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@ibihim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 45b49aa link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants