MGMT-19622: Proxy setting with special characters are ignored when minimal ISO is used

[dudyas6]

This PR is to solve an issue where discovering nodes with minimal iso and authenticated proxy with special characters will fail, same as #6356, need to escape '%' with '%%' in order to properly pass the Environment variables to coreos-livepxe-rootfs service in order to properly boot the node with minimal iso

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@dudyas6: This pull request references MGMT-19622 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@dudyas6: This pull request references MGMT-19622 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

This PR is to solve an issue where discovering nodes with minimal iso and authenticated proxy with special characters will fail, same as #6356, need to escape '%' with '%%' in order to properly pass the Environment variables to coreos-livepxe-rootfs service in order to properly boot the node with minimal iso

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• [] No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dudyas6: This pull request references MGMT-19622 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

This PR is to solve an issue where discovering nodes with minimal iso and authenticated proxy with special characters will fail, same as #6356, need to escape '%' with '%%' in order to properly pass the Environment variables to coreos-livepxe-rootfs service in order to properly boot the node with minimal iso

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• [] No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@dudyas6: This pull request references MGMT-19622 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

This PR is to solve an issue where discovering nodes with minimal iso and authenticated proxy with special characters will fail, same as #6356, need to escape '%' with '%%' in order to properly pass the Environment variables to coreos-livepxe-rootfs service in order to properly boot the node with minimal iso

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (816a96b) to head (a0b1832).
Report is 10 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7315      +/-   ##
==========================================
- Coverage   67.97%   67.94%   -0.04%     
==========================================
  Files         300      300              
  Lines       41014    41118     +104     
==========================================
+ Hits        27880    27938      +58     
- Misses      10632    10675      +43     
- Partials     2502     2505       +3     

Files with missing lines	Coverage Δ
internal/isoeditor/rhcos.go	58.33% <100.00%> (ø)

... and 5 files with indirect coverage changes

[dudyas6]

/retest

[dudyas6]

/retest

[jhernand]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dudyas6, jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e3888ea and 2 for PR HEAD a0b1832 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e3888ea and 2 for PR HEAD a0b1832 in total

[jhernand]

/test e2e-agent-compact-ipv4

[dudyas6]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 39bc1ae and 1 for PR HEAD a0b1832 in total

[jhernand]

/test e2e-agent-compact-ipv4

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 39bc1ae and 2 for PR HEAD a0b1832 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 39bc1ae and 2 for PR HEAD a0b1832 in total

[dudyas6]

/test e2e-agent-compact-ipv4

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 39bc1ae and 2 for PR HEAD a0b1832 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 39bc1ae and 2 for PR HEAD a0b1832 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 39bc1ae and 2 for PR HEAD a0b1832 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 444bfdf and 1 for PR HEAD a0b1832 in total

[openshift-ci]

@dudyas6: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-subsystem-kubeapi-aws	a0b1832	link	true	/test edge-subsystem-kubeapi-aws
ci/prow/edge-subsystem-aws	a0b1832	link	true	/test edge-subsystem-aws
ci/prow/edge-e2e-ai-operator-ztp	a0b1832	link	unknown	/test edge-e2e-ai-operator-ztp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.