Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-19903: Disable ODF and OpenShift AI Operators for Oracle (OCI) #7341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MGMT-19903: Disable ODF and OpenShift AI Operators for Oracle (OCI) #7341

wants to merge 1 commit into from

Conversation

yoavsc0302
Copy link

Linked Issue

Closes MGMT-19903

Summary

This PR updates the Assisted Installer service to disable OpenShift AI and OpenShift Data Foundation operators when integrating with OCI (Oracle Cloud Infrastructure).
Previously, these operators were available for Oracle, but this change ensures they are now disabled when OCI is selected as the platform.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2025 •
edited by openshift-ci bot
Loading

@yoavsc0302: This pull request references MGMT-19903 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Linked Issue

Closes MGMT-19903

Summary

This PR updates the Assisted Installer service to disable OpenShift AI and OpenShift Data Foundation operators when integrating with OCI (Oracle Cloud Infrastructure).
Previously, these operators were available for Oracle, but this change ensures they are now disabled when OCI is selected as the platform.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 24, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yoavsc0302
Once this PR has been reviewed and has the lgtm label, please assign tsorya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.97%. Comparing base (39bc1ae) to head (b140755).

Files with missing lines Patch % Lines
internal/featuresupport/features_olm_operators.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7341   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         300      300           
  Lines       41014    41018    +4     
=======================================
+ Hits        27878    27883    +5     
+ Misses      10633    10632    -1     
  Partials     2503     2503
Files with missing lines Coverage Δ
internal/featuresupport/features_olm_operators.go 81.23% <50.00%> (-0.34%) ⬇️

... and 2 files with indirect coverage changes

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 24, 2025

@yoavsc0302: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 b140755 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

adriengentil
adriengentil reviewed Feb 24, 2025
View reviewed changes
internal/featuresupport/features_olm_operators.go
@@ -122,6 +122,10 @@ func (feature *OdfFeature) getSupportLevel(filters SupportLevelFilters) models.S
return models.SupportLevelUnavailable
}

if filters.ExternalPlatformName != nil && *filters.ExternalPlatformName == "oci" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be able to leverage the getIncompatibleFeatures below. You can look at how it's done for nmstate:
https://github.com/openshift/assisted-service/blob/master/internal/featuresupport/features_olm_operators.go#L733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriengentil adriengentil adriengentil left review comments

@mlorenzofr mlorenzofr Awaiting requested review from mlorenzofr

@paul-maidment paul-maidment Awaiting requested review from paul-maidment

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoavsc0302 @openshift-ci-robot @adriengentil