Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Update README with testing image instructions, TOC #2638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yoavsc0302
Copy link

Description

This PR updates the README.md file with the following improvements:

  • Added missing Table of Contents (ToC) headlines for better navigation.
  • Added instructions for updating the assisted-service image in a running deployment:
    • Using oc set image to update the deployment.
    • Handling same-tag updates with oc rollout restart and oc delete pods.
    • Verification steps to ensure the new image is applied.
    • Summary section for quick reference.

Why?

  • The README previously lacked instructions on how to update the assisted-service image in a running environment.
  • Some important sections were missing from the ToC, making navigation harder.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2025
@openshift-ci-robot
Copy link

@yoavsc0302: This pull request explicitly references no jira issue.

In response to this:

Description

This PR updates the README.md file with the following improvements:

  • Added missing Table of Contents (ToC) headlines for better navigation.
  • Added instructions for updating the assisted-service image in a running deployment:
  • Using oc set image to update the deployment.
  • Handling same-tag updates with oc rollout restart and oc delete pods.
  • Verification steps to ensure the new image is applied.
  • Summary section for quick reference.

Why?

  • The README previously lacked instructions on how to update the assisted-service image in a running environment.
  • Some important sections were missing from the ToC, making navigation harder.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 24, 2025
@openshift-ci openshift-ci bot requested review from danmanor and rccrdpccl February 24, 2025 15:14
Copy link

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yoavsc0302
Once this PR has been reviewed and has the lgtm label, please assign eifrach for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 24, 2025

@yoavsc0302: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants