Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.14] CM-470: Cleanup kube-rbac-proxy #191

Open
wants to merge 1 commit into
base: release-1.14
Choose a base branch
from
Open

[release-1.14] CM-470: Cleanup kube-rbac-proxy #191

wants to merge 1 commit into from

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Jan 19, 2025

Manual cherry-pick of #100

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 19, 2025 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-436 which is a valid jira issue.

In response to this:

Manual cherry-pick of #100

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swghosh
Once this PR has been reviewed and has the lgtm label, please assign trilokgeer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swghosh swghosh force-pushed the 1.14/cleanup-kube-rbac-proxy branch from a713a85 to 8d74c79 Compare January 20, 2025 08:47
@swghosh
Copy link
Member Author

swghosh commented Jan 20, 2025

@bharath-b-rh PTAL, thanks!

@swghosh swghosh changed the title [release-1.14] CM-436: Cleanup kube-rbac-proxy [release-1.14] CM-470: Cleanup kube-rbac-proxy Jan 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 21, 2025 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references CM-470 which is a valid jira issue.

In response to this:

Manual cherry-pick of #100

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharath-b-rh bharath-b-rh bharath-b-rh left review comments

@TrilokGeer TrilokGeer Awaiting requested review from TrilokGeer

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swghosh @openshift-ci-robot @bharath-b-rh