-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: RELEASE BLOCKER(March 1, 2025): add fbc-fips-check task to FBC pipeline #230
base: release-1.14
Are you sure you want to change the base?
Conversation
This commit adds the fbc-fips-check to the FBC pipeline. It also adds a template file named images-mirror-set.yaml which is required by the FIPS task itself and will be used by other tasks in the future. Signed-off-by: yashvardhannanavati <[email protected]>
/ok-to-test |
@yashvardhannanavati: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, yashvardhannanavati The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Who should merge this?
All products building FBC fragments in Konflux are requested to merge this change irrespective of whether the product is intended for FIPS mode or not.
Beginning March 1, 2025, the fbc-fips-task is going to be a required task in the Konflux
pipeline. This means, your release will be blocked if this task is not present in your pipeline run.
What if our product is not designed to operate in FIPS mode? Do we still need this task?
The answer is yes. If your product is not designed to operate in FIPS mode, the task will identify that and will
automatically skip the FIPS scan. However, the task still needs to be a part of your pipeline.
What changes are included in this PR?
images-mirror-set.yaml
to your.tekton
directory with an example in it. This file is anImageDigestMirrorSet
required by the task to access any unreleased bundle image in your FBC fragment. For example, say your FBC fragment contains an unreleased bundle pullspecregistry.redhat.io/my-namespace/my-repo
which will be unavailable at build time on the prod registry. You can specify a mirror likequay.io/my-namespace/my-public-repo
from where the task can access the unreleased image. Mirrors can be specified for bundle images and their related images.What should we do after this PR is merged?
.tekton/images-mirror-set.yaml
file with mirrors for those pullspecs so the task can access them during build time. Please keep the.tekton/images-mirror-set.yaml
file updated to avoid delays in releases.