Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add resource limits and requests flags for ACME HTTP01 solver pods #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

appiepollo14
Copy link

There is no supported overrideArgs to provide resources / limits for the solver pod. With this PR, those are to become accepted args.

@openshift-ci openshift-ci bot requested review from swghosh and TrilokGeer January 29, 2025 18:09
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: appiepollo14
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 29, 2025
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

Hi @appiepollo14. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@appiepollo14
Copy link
Author

@swghosh @TrilokGeer any update in this PR please.

@swghosh
Copy link
Member

swghosh commented Feb 3, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2025
@appiepollo14
Copy link
Author

Great @swghosh whats next

@swghosh
Copy link
Member

swghosh commented Feb 11, 2025

@appiepollo14 thanks for your PR,
we have the RFE-7060 to track this further.

Copy link
Contributor

openshift-ci bot commented Feb 11, 2025

@appiepollo14: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants