-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test/e2e/testdata
to use go template based replacements
#247
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
/test e2e-operator |
1 similar comment
/test e2e-operator |
for extensible replacement of field values Signed-off-by: Swarup Ghosh <[email protected]>
930a8ce
to
63e232e
Compare
test/e2e/testdata
to use go template based replacements
@swghosh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swghosh Thanks for this enhancement!
Assuming you have already examined this patch locally to see if the replacements work as expected, I don’t foresee anything preventing us from merging this PR.
/label qe-approved
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lunarwhite, swghosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For extensible replacement of field values in the yaml(s) used within e2e
testdata/
through config structs,the go
text/template
allows for better replacement support; aids readability as well.