Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test/e2e/testdata to use go template based replacements #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Feb 23, 2025

For extensible replacement of field values in the yaml(s) used within e2e testdata/ through config structs,
the go text/template allows for better replacement support; aids readability as well.

Copy link
Contributor

openshift-ci bot commented Feb 23, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2025
@swghosh
Copy link
Member Author

swghosh commented Feb 23, 2025

/test e2e-operator

1 similar comment
@swghosh
Copy link
Member Author

swghosh commented Feb 23, 2025

/test e2e-operator

@swghosh swghosh changed the title refactor: Use go text/template in e2e testdata Refactor e2e testdata to use go template based replacements Feb 24, 2025
@swghosh swghosh marked this pull request as ready for review February 24, 2025 06:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@openshift-ci openshift-ci bot requested review from deads2k and TrilokGeer February 24, 2025 06:47
for extensible replacement of field values

Signed-off-by: Swarup Ghosh <[email protected]>
@swghosh swghosh force-pushed the refactor/template-for-testdata branch from 930a8ce to 63e232e Compare February 24, 2025 07:15
@swghosh swghosh changed the title Refactor e2e testdata to use go template based replacements Refactor test/e2e/testdata to use go template based replacements Feb 24, 2025
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swghosh Thanks for this enhancement!

Assuming you have already examined this patch locally to see if the replacements work as expected, I don’t foresee anything preventing us from merging this PR.

/label qe-approved
/lgtm

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 25, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lunarwhite, swghosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants