Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: STOR-2267: Run SELinux warning controller #834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsafrane
Copy link

selinux-warning-controller is an optional controller in KCM that emits metrics + events about SELinux usage of persistent volumes in the cluster.

Since most Kubernetes distros don't care about SELinux, this controller needs explicit opt-in on KCM cmdline.
OCP needs the controller:

  • to explain to users why their pods may not be running.
  • to collect metrics about such promebatic pods, to emit alerts and telemetry.

The controller is disabled by default in Kubernetes 1.32 (under SELinuxChangePolicy feature gate).

Enhancement: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling

WIP: for manual testing

selinux-warning-controller is an optional controller in KCM that emits
metrics + events about SELinux usage of persistent volumes in the cluster.

Since most Kubernetes distros don't care about SELinux, this controller
needs explicit opt-in on KCM cmdline.
OCP needs the controller:
- to explain to users why their pods may not be running.
- to collect metrics about such promebatic pods, to emit alerts and
  telemetry.

The controller is disabled by default in Kubernetes 1.32
(under SELinuxChangePolicy feature gate).

Enhancement: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2025
@jsafrane jsafrane changed the title WIP: Run SELinux warning controller WIP: STOR-2267: Run SELinux warning controller Feb 25, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 25, 2025

@jsafrane: This pull request references STOR-2267 which is a valid jira issue.

In response to this:

selinux-warning-controller is an optional controller in KCM that emits metrics + events about SELinux usage of persistent volumes in the cluster.

Since most Kubernetes distros don't care about SELinux, this controller needs explicit opt-in on KCM cmdline.
OCP needs the controller:

  • to explain to users why their pods may not be running.
  • to collect metrics about such promebatic pods, to emit alerts and telemetry.

The controller is disabled by default in Kubernetes 1.32 (under SELinuxChangePolicy feature gate).

Enhancement: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling

WIP: for manual testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit d2a9ed4 link true /test unit
ci/prow/e2e-aws-ovn-upgrade d2a9ed4 link true /test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants