Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove networks.config.openshift.io which is already instantiated by cluster-config-operator #124

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

soltysh
Copy link

@soltysh soltysh commented Mar 14, 2019

Namely this is the place https://github.com/openshift/cluster-config-operator/blob/master/manifests/0000_05_config-operator_01_network.crd.yaml and that is guaranteed to be instantiated before you run your operator.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2019
@soltysh
Copy link
Author

soltysh commented Mar 14, 2019

/assign @squeed

@deads2k
Copy link
Contributor

deads2k commented Mar 14, 2019

Namely this is the place https://github.com/openshift/cluster-config-operator/blob/master/manifests/0000_05_config-operator_01_network.crd.yaml and that is guaranteed to be instantiated before you run your operator.

and that cluster-config-operator image provides a render command used by the installer to produce manifests for config.openshift.io CRDs because operators rely upon those resources for determining how to behavior across components.

@deads2k deads2k closed this Mar 14, 2019
@deads2k deads2k reopened this Mar 14, 2019
@deads2k
Copy link
Contributor

deads2k commented Mar 14, 2019

sorry, wrong button.

@squeed
Copy link
Contributor

squeed commented Mar 14, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@squeed
Copy link
Contributor

squeed commented Mar 14, 2019

aws igw creation timeout
/retest

@openshift-merge-robot openshift-merge-robot merged commit 455bc5f into openshift:master Mar 14, 2019
@soltysh soltysh deleted the drop_crd branch March 15, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants