Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-49744: OVN-K, CUDN CRD: Block namespace-selector with zero-rules #2633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-49744: OVN-K, CUDN CRD: Block namespace-selector with zero-rules #2633

wants to merge 1 commit into from

Conversation

ormergi
Copy link
Contributor

@ormergi ormergi commented Jan 30, 2025

Update CUDN CRD according to [1]: add API validation to prevent CUDN CR selection all namespaces in the cluster.

[1] ovn-kubernetes/ovn-kubernetes#4963

@ormergi
cudn,crd: Do not allow selecting all namespaces
622592f 
Update CUDN CRD according to [1], add API validation to prevent CUDN CR
selection all namespaces in the cluster.

[1] ovn-kubernetes/ovn-kubernetes#4963

Signed-off-by: Or Mergi <[email protected]>
@openshift-ci openshift-ci bot requested review from danwinship and tssurya January 30, 2025 16:29
@ormergi
Copy link
Contributor Author

ormergi commented Jan 30, 2025

/cherrypick release-4.18

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ormergi
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot
Copy link

@ormergi: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ormergi
Copy link
Contributor Author

ormergi commented Jan 30, 2025

/cc @kyrtapz

@openshift-ci openshift-ci bot requested a review from kyrtapz January 30, 2025 16:32
@ormergi ormergi changed the title cudn,crd: Do not allow selecting all namespaces OVN-K, CUDN CRD: Block namespace-selector with zero-rules Jan 30, 2025
@ormergi ormergi changed the title OVN-K, CUDN CRD: Block namespace-selector with zero-rules OCPBUGS-49744: OVN-K, CUDN CRD: Block namespace-selector with zero-rules Feb 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 2, 2025
@openshift-ci-robot
Copy link
Contributor

@ormergi: This pull request references Jira Issue OCPBUGS-49744, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update CUDN CRD according to [1]: add API validation to prevent CUDN CR selection all namespaces in the cluster.

[1] ovn-kubernetes/ovn-kubernetes#4963

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 2, 2025
@ormergi
Copy link
Contributor Author

ormergi commented Feb 2, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 2, 2025
@openshift-ci-robot
Copy link
Contributor

@ormergi: This pull request references Jira Issue OCPBUGS-49744, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 2, 2025
@ormergi
Copy link
Contributor Author

ormergi commented Feb 2, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 2, 2025
@ormergi
Copy link
Contributor Author

ormergi commented Feb 2, 2025

/retest-required

@ormergi
Copy link
Contributor Author

ormergi commented Feb 2, 2025

/test security

@ormergi
Copy link
Contributor Author

ormergi commented Feb 2, 2025

/retest-required

1 similar comment
@ormergi
Copy link
Contributor Author

ormergi commented Feb 2, 2025

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 2, 2025

@ormergi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt 622592f link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-ovn-step-registry 622592f link false /test e2e-ovn-step-registry
ci/prow/e2e-aws-ovn-single-node 622592f link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration 622592f link false /test e2e-aws-ovn-shared-to-local-gateway-mode-migration
ci/prow/e2e-ovn-hybrid-step-registry 622592f link false /test e2e-ovn-hybrid-step-registry
ci/prow/4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade 622592f link false /test 4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 622592f link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-serial 622592f link false /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-local-to-shared-gateway-mode-migration 622592f link false /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
ci/prow/okd-scos-e2e-aws-ovn 622592f link false /test okd-scos-e2e-aws-ovn
ci/prow/4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade 622592f link false /test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
ci/prow/security 622592f link false /test security
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 622592f link true /test e2e-metal-ipi-ovn-ipv6-ipsec

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship Awaiting requested review from danwinship

@tssurya tssurya Awaiting requested review from tssurya

@kyrtapz kyrtapz Awaiting requested review from kyrtapz

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees
No one assigned
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ormergi @openshift-cherrypick-robot @openshift-ci-robot