Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNTRLPLANE-112: Update managed Azure HCP cloud network config #2647

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryan-cox
Copy link
Member

This PR updates the parameters needed for authentication with Azure on managed Azure HCP. The client ID and tenant ID fields are removed since they are not needed for the new managed Azure HCP authentication type, UserAssignedIdentityCredentials. AzureManagedCertPath was renamed to AzureManagedCredsPath since this object now represents a credentials object but will still be mounted to the pod.

This commit updates the parameters needed for authentication with Azure
on managed Azure HCP. The client ID and tenant ID fields are removed
since they are not needed for the new managed Azure HCP authentication
type, UserAssignedIdentityCredentials. AzureManagedCertPath was renamed
to AzureManagedCredsPath since this object now represents a credentials
object but will still be mounted to the pod.

Signed-off-by: Bryan Cox <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2025

@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue.

In response to this:

This PR updates the parameters needed for authentication with Azure on managed Azure HCP. The client ID and tenant ID fields are removed since they are not needed for the new managed Azure HCP authentication type, UserAssignedIdentityCredentials. AzureManagedCertPath was renamed to AzureManagedCredsPath since this object now represents a credentials object but will still be mounted to the pod.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2025
Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bryan-cox
Copy link
Member Author

This PR is needed before this PR can be merged - openshift/hypershift#5621.

Copy link
Contributor

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryan-cox
Once this PR has been reviewed and has the lgtm label, please assign jacobtanenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants