Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "centos" to supported OS ids #2652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add "centos" to supported OS ids #2652

wants to merge 1 commit into from
+3 −3

Conversation

Prashanth684
Copy link

As we move to using pure centos bootimages for OKD, support the "centos" ID as the ID will not be "scos" anymore.

@openshift-ci openshift-ci bot requested review from kyrtapz and tssurya February 22, 2025 05:02
@Prashanth684
Copy link
Author

/retest

@Prashanth684 Prashanth684 changed the title Add "centos" to supported OS id's Add "centos" to supported OS ids Feb 24, 2025
@dougbtv
Copy link
Member

dougbtv commented Feb 25, 2025

/approve

@dougbtv
Copy link
Member

dougbtv commented Feb 25, 2025

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dougbtv
Copy link
Member

dougbtv commented Feb 25, 2025

/retest-required

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

New changes are detected. LGTM label has been removed.

@Prashanth684
Add "centos" to supported OS id's
ac08fa2 
As we move to using pure centos bootimages for OKD, support the
"centos" ID as the ID will not be "scos" anymore.
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

@Prashanth684: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn ac08fa2 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node ac08fa2 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 ac08fa2 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-ovn-techpreview ac08fa2 link true /test e2e-gcp-ovn-techpreview
ci/prow/e2e-aws-hypershift-ovn-kubevirt ac08fa2 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade ac08fa2 link false /test 4.19-upgrade-from-stable-4.18-e2e-azure-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec ac08fa2 link true /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/security ac08fa2 link false /test security
ci/prow/e2e-aws-ovn-windows ac08fa2 link true /test e2e-aws-ovn-windows
ci/prow/e2e-ovn-ipsec-step-registry ac08fa2 link true /test e2e-ovn-ipsec-step-registry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684
Copy link
Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrtapz kyrtapz Awaiting requested review from kyrtapz

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@dougbtv dougbtv

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Prashanth684 @dougbtv