-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump patternfly* to latest versions to pick up bug fixes #1238
Bump patternfly* to latest versions to pick up bug fixes #1238
Conversation
thanks for starting this branch @rhamilto ! I will try to start digging on some of the issues referenced in the PR and ones listed above. Please continue adding here or in the doc and we will try to resolve a.s.a.p. |
We tested a fix for the nav expand today: We should be able to release and update you on Monday. As far as the modal goes, I recommend just overriding the background-image CSS for now:
We would normally override Will continue investigating other issues as we have time next week @rhamilto . |
80da9f5
to
4d4df25
Compare
5a9216e
to
971ecf9
Compare
//cc @rhamilto pr patternfly/patternfly-react#1489 fixes the inputgroup typescript problem. thanks. |
updated 1490 just now. It should fix the nav issues you were experiencing. The edge case we were seeing was due to the This should resolve it. |
@rhamilto - actually, it seems the existing state still takes priority right now. In that use case we seem to pass |
559a466
to
e305c29
Compare
@rhamilto I talked it over with Matt C and we think that in this case the group should stay collapsed so that we don't override the users decision to collapse it. In other cases, the relevant category should still expand when navigating to a new section |
/retest |
e305c29
to
be392bb
Compare
/retest |
ada2cf1
to
62e9c79
Compare
62e9c79
to
8d9f0a3
Compare
tsconfig.json changes removed, unit tests fixed. @spadgett PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
Note: because PatternFly is unstable, I'm locking the version numbers down in this PR.
Fixes https://jira.coreos.com/browse/CONSOLE-1236
And adds now-available separator between
Config Maps
andCron Jobs
in theWorkloads
nav section.