Bug 1678195: Prevent unmounting and mounting of create secret form #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/M
/retest |
spadgett
reviewed
Mar 18, 2019
jhadvig
force-pushed
the
BZ1678195
branch
2 times, most recently
from
89b1375 to
d971193
Compare
|
@spadgett comments addressed |
|
spadgett
reviewed
Mar 18, 2019
| const secretTypeAbstraction = toTypeAbstraction(this.props.obj.data); | ||
| this.setState({ | ||
| formComponent: secretFormFactory(secretTypeAbstraction), | ||
| secretTypeAbstraction: secretTypeAbstraction}); |
There was a problem hiding this comment.
Suggested change
| secretTypeAbstraction: secretTypeAbstraction}); | |
| secretTypeAbstraction, | |
| }); |
spadgett
reviewed
Mar 18, 2019
| const secretTypeAbstraction = toTypeAbstraction(props.obj.data); | ||
| const SecretFormComponent = secretFormFactory(secretTypeAbstraction); | ||
| const fixed = _.reduce(props.fixedKeys, (acc, k) => ({...acc, k: _.get(props.obj.data, k)}), {}); | ||
| return <StatusBox {...props.obj}> |
There was a problem hiding this comment.
I think this will break error handling if the secret doesn't exist.
There was a problem hiding this comment.
not really sure how, since the StatusBox component is mainly operating with loaded and loadError properties, that are supplied by Firehose
|
/retest |
/retest |
/retest |
spadgett
approved these changes
Mar 19, 2019
| } | ||
| render() { | ||
| const { obj, fixedKeys} = this.props; | ||
| const { secretTypeAbstraction } = this.state; |
There was a problem hiding this comment.
nit: you could use destructuring here to avoid the assignment below on line 903
Suggested change
| const { secretTypeAbstraction } = this.state; | |
| const { secretTypeAbstraction, formComponent: SecretFormComponent } = this.state; |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to rewrite the
SecretLoadingWrappercomponent from stateless to stateful .../assign @spadgett
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1678195