Dockerfile: do not generate the front-end code #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the steps from Dockerfile that generates the front-end code. Instead the code is committed to the repository. Note that the front-end code will need to be regenerated and updated every time a new release has to be made.
|
@mxinden is merging this into Otherwise this lgtm 👍 |
|
@brancz as far as I know yes. None of the |
|
For the record, the effort of changing the release process is tracked here: https://jira.coreos.com/browse/MON-330. |
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jun 24, 2020
* Clean up influxdb.md Mostly typos, some wording consistency and clarification * feature-rich Co-Authored-By: Marcus Olsson <[email protected]> * Query editor wording Co-Authored-By: Marcus Olsson <[email protected]> * Update docs/sources/features/datasources/influxdb.md Co-Authored-By: Marcus Olsson <[email protected]> * One less "you can" Co-Authored-By: Marcus Olsson <[email protected]> * Query example wording Co-Authored-By: Marcus Olsson <[email protected]> * Remove extraneous newline * Use less words Co-Authored-By: Marcus Olsson <[email protected]> * Remove more newlines * Use present tense * Add missing 'to' * Summary fixup Co-Authored-By: Diana Payton <[email protected]> * Down with gerunds in headers Co-Authored-By: Diana Payton <[email protected]> * consistent tenses Co-Authored-By: Diana Payton <[email protected]> * Remove br html tag #1 Co-Authored-By: Diana Payton <[email protected]> * Remove br html tag #2 Co-Authored-By: Diana Payton <[email protected]> * Less future tense Co-Authored-By: Diana Payton <[email protected]> * Spell out location of annotations view Co-Authored-By: Diana Payton <[email protected]> * Query input fixups Co-Authored-By: Diana Payton <[email protected]> * More detail on where to access InfluxDB editor Co-Authored-By: Diana Payton <[email protected]> * Provisioning fixups Co-Authored-By: Diana Payton <[email protected]>
arajkumar
pushed a commit
to arajkumar/grafana
that referenced
this pull request
Dec 21, 2021
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jan 19, 2022
* add core plugin flow * add instrumentation * move func * remove cruft * support external backend plugins * refactor + clean up * remove comments * refactor loader * simplify core plugin path arg * cleanup loggers * move signature validator to plugins package * fix sig packaging * cleanup plugin model * remove unnecessary plugin field * add start+stop for pm * fix failures * add decommissioned state * export fields just to get things flowing * fix comments * set static routes * make image loading idempotent * merge with backend plugin manager * re-use funcs * reorder imports + remove unnecessary interface * add some TODOs + remove unused func * remove unused instrumentation func * simplify client usage * remove import alias * re-use backendplugin.Plugin interface * re order funcs * improve var name * fix log statements * refactor data model * add logic for dupe check during loading * cleanup state setting * refactor loader * cleanup manager interface * add rendering flow * refactor loading + init * add renderer support * fix renderer plugin * reformat imports * track errors * fix plugin signature inheritance * name param in interface * update func comment * fix func arg name * introduce class concept * remove func * fix external plugin check * apply changes from pm-experiment * fix core plugins * fix imports * rename interface * comment API interface * add support for testdata plugin * enable alerting + use correct core plugin contracts * slim manager API * fix param name * fix filter * support static routes * fix rendering * tidy rendering * get tests compiling * fix install+uninstall * start finder test * add finder test coverage * start loader tests * add test for core plugins * load core + bundled test * add test for nested plugin loading * add test files * clean interface + fix registering some core plugins * refactoring * reformat and create sub packages * simplify core plugin init * fix ctx cancel scenario * migrate initializer * remove Init() funcs * add test starter * new logger * flesh out initializer tests * refactoring * remove unused svc * refactor rendering flow * fixup loader tests * add enabled helper func * fix logger name * fix data fetchers * fix case where plugin dir doesn't exist * improve coverage + move dupe checking to loader * remove noisy debug logs * register core plugins automagically * add support for renderer in catalog * make private func + fix req validation * use interface * re-add check for renderer in catalog * tidy up from moving to auto reg core plugins * core plugin registrar * guards * copy over core plugins for test infra * all tests green * renames * propagate new interfaces * kill old manager * get compiling * tidy up * update naming * refactor manager test + cleanup * add more cases to finder test * migrate validator to field * more coverage * refactor dupe checking * add test for plugin class * add coverage for initializer * split out rendering * move * fixup tests * fix uss test * fix frontend settings * fix grafanads test * add check when checking sig errors * fix enabled map * fixup * allow manual setup of CM * rename to cloud-monitoring * remove TODO * add installer interface for testing * loader interface returns * tests passing * refactor + add more coverage * support 'stackdriver' * fix frontend settings loading * improve naming based on package name * small tidy * refactor test * fix renderer start * make cloud-monitoring plugin ID clearer * add plugin update test * add integration tests * don't break all if sig can't be calculated * add root URL check test * add more signature verification tests * update DTO name * update enabled plugins comment * update comments * fix linter * revert fe naming change * fix errors endpoint * reset error code field name * re-order test to help verify * assert -> require * pm check * add missing entry + re-order * re-check * dump icon log * verify manager contents first * reformat * apply PR feedback * apply style changes * fix one vs all loading err * improve log output * only start when no signature error * move log * rework plugin update check * fix test * fix multi loading from cfg.PluginSettings * improve log output #2 * add error abstraction to capture errors without registering a plugin * add debug log * add unsigned warning * e2e test attempt * fix logger * set home path * prevent panic * alternate * ugh.. fix home path * return renderer even if not started * make renderer plugin managed * add fallback renderer icon, update renderer badge + prevent changes when renderer is installed * fix icon loading * rollback renderer changes * use correct field * remove unneccessary block * remove newline * remove unused func * fix bundled plugins base + module fields * remove unused field since refactor * add authorizer abstraction * loader only returns plugins expected to run * fix multi log output
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jan 19, 2022
* add stream handler support to plugin.Client * nil instead of empty resp Co-authored-by: Marcus Efraimsson <[email protected]> * nil instead of empty resp #2 Co-authored-by: Marcus Efraimsson <[email protected]> Co-authored-by: Marcus Efraimsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the steps from Dockerfile that generates the front-end code. Instead the code is committed to the repository. Note that the front-end code will need to be regenerated and updated every time a new release has to be made.
cc @brancz