-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-112: Enable image registry to use managed identity v3 #5655
base: main
Are you sure you want to change the base?
Conversation
@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bryan-cox: This pull request references CNTRLPLANE-112 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d127f32
to
6b941a0
Compare
Successfully tested this yesterday. See this comment for more details - openshift/cluster-image-registry-operator#1174 (comment). |
This commit enables the cluster image registry operator to use managed identity version 3. Signed-off-by: Bryan Cox <[email protected]>
6b941a0
to
dea749f
Compare
/hold openshift/cluster-image-registry-operator#1174 needs to merge first then this PR can merge. |
@bryan-cox: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This PR enables image registry to use managed identity v3
Which issue(s) this PR fixes:
Part of CNTRLPLANE-112
Checklist