Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-50698: add region to AWS creds passed to operators managed by CPO #5670

Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] OCPBUGS-50698: add region to AWS creds passed to operators managed by CPO #5670

wants to merge 1 commit into from
+82 −10

Conversation

BraeTroutman
Copy link
Contributor

This is a manual cherry-pick of #5595

/assign openshift-ci-bot

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

@BraeTroutman: GitHub didn't allow me to assign the following users: openshift-ci-bot.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is a manual cherry-pick of #5595

/assign openshift-ci-bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2025
@openshift-ci-robot
Copy link

@BraeTroutman: This pull request references Jira Issue OCPBUGS-50698, which is invalid:

  • expected dependent Jira Issue OCPBUGS-50697 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #5595

/assign openshift-ci-bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hasueki February 19, 2025 16:55
@openshift-ci openshift-ci bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Feb 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BraeTroutman
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BraeTroutman BraeTroutman changed the title [release-4.16] OCPBUGS-50698: OCPBUGS-50699: add region to AWS creds passed to operators managed by CPO [release-4.16] OCPBUGS-50698: add region to AWS creds passed to operators managed by CPO Feb 19, 2025
@BraeTroutman
Copy link
Contributor Author

/retest

@BraeTroutman
add region to AWS creds passed to operators
9db7893 
this will ensure that clients build by these operators will point
to the same AWS region that the HCP itself is deployed in when
interacting with cloud resources.
@wking
Copy link
Member

wking commented Feb 24, 2025

The TestCreateClusterRequestServingIsolation failure:

    util.go:364: Successfully waited for 1 nodes to become ready for NodePool clusters/1f5e4232d69f44732389-mgmt-reqserving-s8gjg in 3m11s
    util.go:364: Failed to wait for 1 nodes to become ready for NodePool clusters/1f5e4232d69f44732389-mgmt-reqserving-gkbsd in 30m0s: context deadline exceeded

seems unrelated.

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@BraeTroutman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@hasueki hasueki Awaiting requested review from hasueki

Assignees
No one assigned
Labels
area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BraeTroutman @openshift-ci-robot @wking