Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-50697: add region to AWS creds passed to operators managed by CPO #5671

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-50697: add region to AWS creds passed to operators managed by CPO #5671

wants to merge 1 commit into from
+80 −8

Conversation

BraeTroutman
Copy link
Contributor

This is a manual cherry-pick of #5595

/assign openshift-ci-bot

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2025
@openshift-ci-robot
Copy link

@BraeTroutman: This pull request references Jira Issue OCPBUGS-50697, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #5595

/assign openshift-ci-bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

@BraeTroutman: GitHub didn't allow me to assign the following users: openshift-ci-bot.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is a manual cherry-pick of #5595

/assign openshift-ci-bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BraeTroutman BraeTroutman changed the base branch from main to release-4.17 February 19, 2025 17:01
@openshift-ci-robot
Copy link

@BraeTroutman: This pull request references Jira Issue OCPBUGS-50697, which is invalid:

  • expected dependent Jira Issue OCPBUGS-50696 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is a manual cherry-pick of #5595

/assign openshift-ci-bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and sjenning February 19, 2025 17:01
@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed do-not-merge/needs-area labels Feb 19, 2025
@BraeTroutman
Copy link
Contributor Author

/retest

1 similar comment
@BraeTroutman
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025 •
edited
Loading

@BraeTroutman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-4-18 262af87 link true /test e2e-aws-4-18
ci/prow/e2e-aks-4-18 262af87 link true /test e2e-aks-4-18
ci/prow/okd-scos-e2e-aws-ovn 262af87 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-upgrade-hypershift-operator 262af87 link true /test e2e-aws-upgrade-hypershift-operator
ci/prow/e2e-aks 262af87 link true /test e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BraeTroutman
Copy link
Contributor Author

/retest

@sjenning
Copy link
Contributor

missing this diff vs the 4.18 PR

https://github.com/openshift/hypershift/pull/5629/files#diff-6995c532d3cc9b0428062dc5d76589196d62dc18751b385d26dcc4d035ea4f1aL246-L247

This on purpose?

@BraeTroutman
add region to AWS creds passed to operators
2718bf1 
this will ensure that clients build by these operators will point
to the same AWS region that the HCP itself is deployed in when
interacting with cloud resources.
@sjenning
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BraeTroutman, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sjenning sjenning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BraeTroutman @openshift-ci-robot @sjenning