CNTRLPLANE-244: Add needed Codecov files to HyperShift #5696
Conversation
This commit adds the needed files to run codecov on HyperShift. See https://github.com/openshift/hive-sops/blob/master/sop/Coverage.md for more information. Signed-off-by: Bryan Cox <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@bryan-cox: This pull request references CNTRLPLANE-244 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/area ci-tooling |
bryan-cox
changed the title
openshift-ci
bot
added
area/ci-tooling
openshift-ci
bot
added
the
area/documentation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-aks |
1 similar comment
|
/test e2e-aks |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| if [[ "${JOB_TYPE}" != "local" ]]; then | ||
| if [[ -z "${ARTIFACT_DIR:-}" ]] || [[ ! -d "${ARTIFACT_DIR}" ]] || [[ ! -w "${ARTIFACT_DIR}" ]]; then | ||
| echo '${ARTIFACT_DIR} must be set for non-local jobs, and must point to a writable directory' >&2 |
There was a problem hiding this comment.
${ARTIFACT_DIR} won't get expanded with single quotes.
| exit 1 | ||
| fi | ||
| curl -sS https://codecov.io/bash -o "${ARTIFACT_DIR}/codecov.sh" | ||
| bash <(cat "${ARTIFACT_DIR}/codecov.sh") -Z -K -f "${COVER_PROFILE}" -r "${REPO_OWNER}/${REPO_NAME}" ${REF_FLAGS} |
There was a problem hiding this comment.
Shouldn't $REF_FLAGS be double quoted to prevent splitting issues?
| curl -sS https://codecov.io/bash -o "${ARTIFACT_DIR}/codecov.sh" | ||
| bash <(cat "${ARTIFACT_DIR}/codecov.sh") -Z -K -f "${COVER_PROFILE}" -r "${REPO_OWNER}/${REPO_NAME}" ${REF_FLAGS} | ||
| else | ||
| bash <(curl -s https://codecov.io/bash) -Z -K -f "${COVER_PROFILE}" -r "${REPO_OWNER}/${REPO_NAME}" ${REF_FLAGS} |
There was a problem hiding this comment.
Shouldn't $REF_FLAGS be double quoted to prevent splitting issues?
What this PR does / why we need it:
This PR adds the needed files to run codecov on HyperShift. See https://github.com/openshift/hive-sops/blob/master/sop/Coverage.md for more information.
Which issue(s) this PR fixes:
Part of CNTRLPLANE-244
Checklist