Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name of RHCOS #1358

Merged
merged 2 commits into from
Mar 4, 2019
Merged

Update name of RHCOS #1358

merged 2 commits into from
Mar 4, 2019

Conversation

ashcrow
Copy link
Member

@ashcrow ashcrow commented Mar 4, 2019 •
edited
Loading

Update troubleshooting.md and the openstack README.md to use the full, proper name of RHCOS.

/cc @mrguitar @jlebon @miabbott @darkmuggle

Related: #1359

@openshift-ci-robot
Copy link
Contributor

@ashcrow: GitHub didn't allow me to request PR reviews from the following users: mrguitar.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Update troubleshooting.md and to use the full, proper name of RHCOS.

/cc @mrguitar @jlebon @miabbott @darkmuggle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2019
@ashcrow ashcrow changed the title troubleshooting.md: Update name of RHCOS Update name of RHCOS Mar 4, 2019
@ashcrow ashcrow mentioned this pull request Mar 4, 2019
Merged
@cgwalters
Copy link
Member

/approve

wking
wking reviewed Mar 4, 2019
View reviewed changes
@ashcrow ashcrow force-pushed the rhcos-name-update branch from e2100bd to 1d09695 Compare March 4, 2019 19:19
@ashcrow
Copy link
Member Author

ashcrow commented Mar 4, 2019

Updated per review. PTAL.

wking
wking reviewed Mar 4, 2019
View reviewed changes
@ashcrow ashcrow force-pushed the rhcos-name-update branch from 1d09695 to 79237be Compare March 4, 2019 22:12
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2019
@wking
Copy link
Member

wking commented Mar 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@openshift-merge-robot openshift-merge-robot merged commit 83d7fca into openshift:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@mrguitar mrguitar mrguitar left review comments

@jlebon jlebon Awaiting requested review from jlebon

@miabbott miabbott Awaiting requested review from miabbott

@darkmuggle darkmuggle Awaiting requested review from darkmuggle

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashcrow @openshift-ci-robot @cgwalters @wking @mrguitar @openshift-merge-robot