Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-2797: images: move container images to RHEL 9 #8196

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Mar 21, 2024

Use RHEL 9 as a base for all our container images.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 21, 2024

@r4f4: This pull request references CORS-2797 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Use RHEL 9 as a base for all our container images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dtantsur and jhixson74 March 21, 2024 15:35
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 21, 2024

/uncc @jhixson74
/cc @patrickdillon @zaneb

@openshift-ci openshift-ci bot requested review from patrickdillon and zaneb and removed request for jhixson74 March 21, 2024 15:41
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 21, 2024

/test images

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 21, 2024

/test okd-images e2e-aws-ovn

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 21, 2024

It seems the test is running from a rhel-8 builder?

openshift-install: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by openshift-install)
openshift-install: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by openshift-install) 

EDIT: yes, I forgot to update https://github.com/openshift/installer/blob/master/.ci-operator.yaml#L1-L4

@r4f4 r4f4 force-pushed the install-rhel-9 branch 4 times, most recently from 16745db to 24af0bb Compare March 21, 2024 22:30
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 21, 2024

Updates:

  • I'd forgotten to update the last layer image (base) which was causing the rhel-9 binaries to run inside a rhel8 container
  • Update the google cloud cli repo as in https://cloud.google.com/sdk/docs/install#rpm
  • Explicitly install python3-pip
  • Removed all python2 packages

/hold
Still need to figure out the openstack and libvirt images fixes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2024
@r4f4 r4f4 force-pushed the install-rhel-9 branch 2 times, most recently from cbce73c to 45419c4 Compare March 25, 2024 16:28
@r4f4
Copy link
Contributor Author

r4f4 commented Mar 25, 2024

e2e-gcp-ovn-upi: seems to need python3-pyOpenSSL lib

CommandException: The signurl command requires the pyopenssl library (try pip install pyopenssl or easy_install pyopenssl)

e2e-metal-*: The installer is being run on some rhel8 along the way.

@r4f4
Copy link
Contributor Author

r4f4 commented Mar 26, 2024

/cc @cfergeau @jaypoulz
For the libvirt image changes
/cc @pierreprinetti
For the openstack image changes

@jaypoulz
Copy link
Contributor

/lgtm
For the changes specific to the libvirt installer. As long as the CI/prow/images job is building, the multi-arch team should be clear. CC @tvardema

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@pierreprinetti
Copy link
Member

pierreprinetti commented Mar 26, 2024

e2e-openstack-nfv-intel and e2e-openstack-proxy are not providing a clean signal in 4.16 yet; their failure here resembles what we get in periodics (we're working on that). The other tests look good, including one UPI run that exercises the changes in how packages are installed (thanks).

/test altinfra-e2e-openstack-capi-ovn

For OpenStack:
/approve
Thank you!

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/altinfra-openstack-capi-manifests

In response to this:

/override ci/prow/altinfra-openstack-capi-manifests
The job is permafailing due to reasons unrelated to this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD e223641 and 2 for PR HEAD 1522568 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7dd2fbc and 1 for PR HEAD 1522568 in total

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 30, 2024

e2e-gcp-ovn-upi: cluster installed. Few e2e failures.
e2e-metal-ipi-ovn-swapped-hosts: e2e failures.
e2e-openstack-dualstack-upi: e2e failures.
e2e-vsphere-upi: e2e failures.

We need this to merge soon so we can coordinate other PRs that need to merge in succession.
/override ci/prow/e2e-azure-ovn-upi ci/prow/e2e-gcp-ovn-upi ci/prow/e2e-vsphere-upi
/skip

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi, ci/prow/e2e-gcp-ovn-upi, ci/prow/e2e-vsphere-upi

In response to this:

e2e-gcp-ovn-upi: cluster installed. Few e2e failures.
e2e-metal-ipi-ovn-swapped-hosts: e2e failures.
e2e-openstack-dualstack-upi: e2e failures.
e2e-vsphere-upi: e2e failures.

We need this to merge soon so we can coordinate other PRs that need to merge in succession.
/override ci/prow/e2e-azure-ovn-upi ci/prow/e2e-gcp-ovn-upi ci/prow/e2e-vsphere-upi
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 30, 2024

/skip

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 30, 2024

/override ci/prow/e2e-aws-ovn ci/prow/e2e-aws-ovn-upi ci/prow/e2e-gcp-ovn ci/prow/e2e-openstack-ovn
cluster installed

@r4f4
Copy link
Contributor Author

r4f4 commented Apr 30, 2024

/override ci/prow/e2e-vsphere-upi
e2e failures.

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-openstack-ovn

In response to this:

/override ci/prow/e2e-aws-ovn ci/prow/e2e-aws-ovn-upi ci/prow/e2e-gcp-ovn ci/prow/e2e-openstack-ovn
cluster installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-vsphere-upi

In response to this:

/override ci/prow/e2e-vsphere-upi
e2e failures.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon patrickdillon merged commit e6b59d5 into openshift:master Apr 30, 2024
40 of 42 checks passed
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-openstack-capi-ovn 85190ab9c3997f7c9b1992e6caed66feec6a2de8 link false /test altinfra-e2e-openstack-capi-ovn
ci/prow/e2e-agent-compact-ipv4 54c6b18cae918d3029ee23179c476b7d662735dc link true /test e2e-agent-compact-ipv4
ci/prow/agent-integration-tests 54c6b18cae918d3029ee23179c476b7d662735dc link true /test agent-integration-tests
ci/prow/e2e-openstack-proxy 1522568 link false /test e2e-openstack-proxy
ci/prow/okd-e2e-aws-ovn-upgrade 1522568 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-metal-assisted 1522568 link false /test e2e-metal-assisted
ci/prow/e2e-gcp-secureboot 1522568 link false /test e2e-gcp-secureboot
ci/prow/e2e-metal-ipi-ovn-swapped-hosts 1522568 link false /test e2e-metal-ipi-ovn-swapped-hosts
ci/prow/e2e-openstack-dualstack-upi 1522568 link false /test e2e-openstack-dualstack-upi
ci/prow/e2e-metal-single-node-live-iso 1522568 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-vsphere-upi 1522568 link true /test e2e-vsphere-upi
ci/prow/e2e-vsphere-upi-zones 1522568 link false /test e2e-vsphere-upi-zones
ci/prow/e2e-gcp-ovn-shared-vpc 1522568 link false /test e2e-gcp-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202404302014.p0.ge6b59d5.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

lleshchi added a commit to lleshchi/hive that referenced this pull request May 21, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request May 21, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request May 21, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request May 23, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request Jun 3, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request Jun 4, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request Jun 10, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request Jun 11, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request Jun 12, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request Jun 17, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
lleshchi added a commit to lleshchi/hive that referenced this pull request Jun 18, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
celebdor pushed a commit to celebdor/hive that referenced this pull request Jun 20, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
celebdor pushed a commit to celebdor/hive that referenced this pull request Jul 5, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
celebdor pushed a commit to celebdor/hive that referenced this pull request Aug 2, 2024
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
2uasimojo pushed a commit to openshift/hive that referenced this pull request Jan 16, 2025
As a result of the openshift installer transitioning from rhel8 to rhel9
(openshift/installer#8196), running
openshift-install in the rhel8 backed hive container in order to install
a cluster in fips mode results in a fips incompatibility.

Create a seperate installmanager binary that runs the install-manager
command previously invoked by hiveutil. Build a rhel8 and rhel9 version
of hive, and copy both versions of installmanager to the installer
container. The directory struture of the provisioning pod is also
adjusted to support this change. Lastly, the installmanager binary
corresponding to the rhel version of the installer container.

Signed-off-by: Leah Leshchinsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.