[release-4.16] OCPBUGS-50547: aws/edge/byovpc: tag edge subnets with shared value

[mtulio]

Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with
kubernetes.io/cluster/:shared.

This change ensures installer is also setting the same cluster tag as regular zones.

This PR is a manual backport of #9452, fixing a typo found on #9480

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-48827, which is invalid:

• expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.19.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
• expected dependent Jira Issue OCPBUGS-49594 to target a version in 4.17.0, 4.17.z, but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with
kubernetes.io/cluster/:shared.

This change ensures installer is also setting the same cluster tag as regular zones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-50547, which is invalid:

• expected dependent Jira Issue OCPBUGS-49975 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with
kubernetes.io/cluster/:shared.

This change ensures installer is also setting the same cluster tag as regular zones.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mtulio. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/asset/cluster/aws/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtulio]

Wait for e2e.
/hold
/jira refresh
/assign @yunjiang29 @patrickdillon
/cherry-pick release-4.15

[openshift-cherrypick-robot]

@mtulio: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

Wait for e2e.
/hold
/jira refresh
/assign @yunjiang29 @patrickdillon
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-50547, which is invalid:

• expected dependent Jira Issue OCPBUGS-49975 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Wait for e2e.
/hold
/jira refresh
/assign @yunjiang29 @patrickdillon
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-vsphere-ovn	eb9c13d	link	false	/test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-imdsv2	eb9c13d	link	false	/test e2e-aws-ovn-imdsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mtulio]

/jira-refresh

[mtulio]

/jira refresh

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-50547, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-49975 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-49975 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mtulio]

Hi @yunjiang29 @patrickdillon , dependent Jira updated. PTAL?
/hold cancel

[yunjiang29]

LGTM