Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Test aro build flag #9506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: Test aro build flag #9506

wants to merge 2 commits into from
+71 −85

Conversation

rna-afk
Copy link
Contributor

@rna-afk rna-afk commented Feb 24, 2025

Testing removal of a piece of ARO code generating
cloud provider secrets to see if ARO installs work.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rna-afk. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from barbacbd and jhixson74 February 24, 2025 07:30
@rna-afk
aro: Remove aro build flag
103b820 
Removing the build flag by checking for the managed by field
in the resource group. If set to ARO, perform all the ARO
specific customizations.
@rna-afk
adding test case changes
6bd93e2
@rna-afk rna-afk force-pushed the test_aro_build_flag branch from 4cf080e to 6bd93e2 Compare February 24, 2025 08:09
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 24, 2025

@rna-afk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack 6bd93e2 link false /test e2e-azurestack
ci/prow/e2e-azure-ovn 6bd93e2 link true /test e2e-azure-ovn
ci/prow/images 6bd93e2 link true /test images
ci/prow/azure-ovn-marketplace-images 6bd93e2 link false /test azure-ovn-marketplace-images
ci/prow/e2e-azure-default-config 6bd93e2 link false /test e2e-azure-default-config
ci/prow/artifacts-images 6bd93e2 link true /test artifacts-images
ci/prow/e2e-aws-ovn 6bd93e2 link true /test e2e-aws-ovn
ci/prow/e2e-azure-ovn-shared-vpc 6bd93e2 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azure-ovn-resourcegroup 6bd93e2 link false /test e2e-azure-ovn-resourcegroup
ci/prow/okd-scos-e2e-aws-ovn 6bd93e2 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbacbd barbacbd Awaiting requested review from barbacbd

@jhixson74 jhixson74 Awaiting requested review from jhixson74

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rna-afk