Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS-1384: Update requirements.txt #2226

Closed
wants to merge 2 commits into from
Closed

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Feb 12, 2025

Description

Update requirements.txt from the current lib set.
Fix the version too.

@openshift-ci openshift-ci bot requested review from bparees and xrajesh February 12, 2025 11:13
Copy link

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be it part of #2154 ?

@onmete
Copy link
Contributor Author

onmete commented Feb 12, 2025

Nope, that one is too hard to make happen.

@xrajesh
Copy link
Contributor

xrajesh commented Feb 13, 2025

Looks good - but I am missing the to understand , what is driving this change - could you please post what is driving this change ? Thank you @onmete

@onmete onmete changed the title Update requirements.txt OLS-1384: Update requirements.txt Feb 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2025

@onmete: This pull request references OLS-1384 which is a valid jira issue.

In response to this:

Description

Update requirements.txt from the current lib set.
Fix the version too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2025
Copy link

openshift-ci bot commented Feb 14, 2025

@onmete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-images 24fffd3 link true /test 4.17-images
ci/prow/fips-image-scan-service 24fffd3 link true /test fips-image-scan-service
ci/prow/4.15-images 24fffd3 link true /test 4.15-images
ci/prow/4.17-e2e-ols-cluster 24fffd3 link true /test 4.17-e2e-ols-cluster
ci/prow/images 24fffd3 link true /test images
ci/prow/4.16-images 24fffd3 link true /test 4.16-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@onmete onmete closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants