Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP DO NOT MERGE test less compressed RPMs #1519

Closed
wants to merge 1 commit into from
Closed

WIP DO NOT MERGE test less compressed RPMs #1519

wants to merge 1 commit into from

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Mar 17, 2023

/hold
/cc

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

@pmtk: GitHub didn't allow me to request PR reviews from the following users: pmtk.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/hold
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

/retest

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

/test e2e-router-smoke-test

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

build log without the change:

2023-03-16T15:53:00.770027545Z [1/2] STEP 5/6: RUN make rpm
2023-03-16T15:58:15.842346006Z [1/2] STEP 6/6: RUN TARGET_ARCH=aarch64 make rpm
2023-03-16T16:03:39.962084758Z [2/2] STEP 1/16

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

/test e2e-router-smoke-test

2 similar comments
@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

/test e2e-router-smoke-test

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

/test e2e-router-smoke-test

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

/retest

1 similar comment
@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

/retest

dhellmann
dhellmann reviewed Mar 17, 2023
View reviewed changes
packaging/rpm/make-rpm.sh
@@ -62,7 +62,7 @@ EOF
# it yields w19.zstdio, which means compression level 19 using zstd algorithm. To
# speed this up it runs w19T8.zstdio, which is the 8 thread version of the same
# algorithm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this comment will also need to be updated.

I wonder if we need any compression at all if this is just for CI?

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

Actually it looks like the difference is within an error, that minute saved might've been just lucky run on CI.
Not sure if worth changed the RHEL/Fedora building defaults

2023-03-17T14:44:48.108607559Z [1/2] STEP 5/6: RUN make rpm
2023-03-17T14:48:32.235223875Z [1/2] STEP 6/6: RUN TARGET_ARCH=aarch64 make rpm
2023-03-17T14:51:56.898985730Z [2/2] STEP 1/16:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2023

@pmtk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-loadbalancer-smoke-test 2fed32d link false /test e2e-loadbalancer-smoke-test
ci/prow/e2e-openshift-conformance-reduced 2fed32d link true /test e2e-openshift-conformance-reduced
ci/prow/e2e-openshift-conformance-reduced-arm 2fed32d link true /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk
Copy link
Member Author

pmtk commented Mar 17, 2023

From further investigation (connected to building RPMs in a container) it seems that bulk of the time is (obviously) spent on compiling go binaries. Given that CI is always starting with clean slate (empty go cache), there's not much to do

@pmtk pmtk closed this Mar 17, 2023
@pmtk pmtk deleted the less-compressed-rpms branch March 17, 2023 18:27
@microshift-rebase-script microshift-rebase-script bot mentioned this pull request Jan 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmtk @dhellmann