Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell MicroShift consistently #369

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Spell MicroShift consistently #369

merged 2 commits into from
Oct 26, 2021

Conversation

fzdarsky
Copy link
Contributor

Signed-off-by: Frank A. Zdarsky [email protected]

Signed-off-by: Frank A. Zdarsky <[email protected]>
@openshift-ci openshift-ci bot requested review from oglok and sallyom October 25, 2021 21:41
@netlify
Copy link

netlify bot commented Oct 25, 2021

✔️ Deploy Preview for microshift ready!

🔨 Explore the source changes: 6db3699

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/617831d09465040008fd4f77

😎 Browse the preview: https://deploy-preview-369--microshift.netlify.app

@osilkin98
Copy link
Contributor

osilkin98 commented Oct 26, 2021

I think the spelling of Microshift makes a lot of sense when you consider the phonetics.

OpenShift works because the n at the end of Open is a stop consonant which obstructs your flow of speech when you say the word out loud, since your tongue has to hit the top of your mouth (try it!), therefore it makes sense that Shift is considered as a different word so the S is naturally capitalized.

MicroShift is a bit different because it ends with ro (a liquid consonant and a vowel), so transitioning to shift feels smoother as if you're just saying Microshift

@mangelajo
Copy link
Contributor

I would also raise for consideration microShift (os just microshift) , as a reference to it's small size ;)

Copy link
Contributor

@husky-parul husky-parul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer microshift instead of MicroShift or Microshift to indicate small size.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2021
@husky-parul husky-parul removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cooktheryan, husky-parul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021

@fzdarsky: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-cli 6db3699 link false /test e2e-openshift-conformance-sig-cli
ci/prow/e2e-openshift-conformance-sig-apps 6db3699 link false /test e2e-openshift-conformance-sig-apps
ci/prow/e2e-openshift-conformance-sig-api-machinery 6db3699 link false /test e2e-openshift-conformance-sig-api-machinery
ci/prow/e2e-openshift-conformance-sig-scheduling 6db3699 link false /test e2e-openshift-conformance-sig-scheduling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants